Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Date picker): missing value accessor and model config #1066

Merged
merged 1 commit into from
May 22, 2024

Conversation

dgonzalezr
Copy link
Collaborator

@dgonzalezr dgonzalezr commented May 22, 2024

Description

Since the bq-date-picker is a form component, we need to add it to the value accessor (Angular) and model config (Vue), but we missed that when the feature was implemented on #1029.

Related Issue

N/A

Documentation

Screenshots (if applicable)

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label May 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dgonzalezr dgonzalezr merged commit de4de39 into main May 22, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/date-picker-value-accessor branch May 22, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants