Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet-mobile): balances - protocolparams #3327

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(wallet-mobile): balances - protocolparams #3327

merged 1 commit into from
Jun 25, 2024

Conversation

stackchain
Copy link
Member

Description / Change(s) / Related issue(s)

  • Protocol params can change per epoch after Conway, added persistence to it
  • Ignoring API errors, falling back to hardcoded values
  • Considering consuming it straight from network-manager since is too tight to flavour

@github-actions github-actions bot added the fix label Jun 25, 2024
@stackchain
Copy link
Member Author

@banklesss the issue with no balances was some throwing not handled, another step to a more off-line first after this PR.

@stackchain stackchain added this to the 5.0.0 milestone Jun 25, 2024
@stackchain stackchain marked this pull request as ready for review June 25, 2024 10:19
@banklesss
Copy link
Contributor

@banklesss the issue with no balances was some throwing not handled, another step to a more off-line first after this PR.

let me know if i can help you with anything 👍🏻

@stackchain stackchain merged commit 821fe4f into develop Jun 25, 2024
3 checks passed
@stackchain stackchain deleted the fix/protocol-params branch June 25, 2024 10:26
@stackchain stackchain mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banklesss banklesss banklesss approved these changes

@michaeljscript michaeljscript Awaiting requested review from michaeljscript

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
5.0.0 "Day & Night"
Development

Successfully merging this pull request may close these issues.
2 participants
@stackchain @banklesss