feature(wallet-mobile): NFTs traits #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
commented
May 27, 2024
banklesss
reviewed
May 27, 2024
|
|
||
| return { | ||
| ...query, | ||
| tokenTraits: query.data, |
There was a problem hiding this comment.
If i am not wrong traits its a property of data right? query.data.traits
would it be a good idea to get the traits so you dont need to use tokenTraits.traits?
or does query.data contain more useful properties?
There was a problem hiding this comment.
ok i see it includes total items property
There was a problem hiding this comment.
return {
...query,
tokenTraits: query.data.traits,
totalItems: query.data.totalItems,
}
Maybe like this?
To avoid tokenTraits.traits
There was a problem hiding this comment.
yap, some info are not important cuz it does have the info before hitting it.
banklesss
approved these changes
May 27, 2024
michaeljscript
approved these changes
May 27, 2024
jorbuedo
approved these changes
May 27, 2024
fbfb60c to
0532115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Change(s) / Related issue(s)
Ticket
YOMO-1457
Note
Please create the ticket if missing it.