Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: portfolio wire up #3241

Merged
merged 76 commits into from
May 10, 2024
Merged

chore: portfolio wire up #3241

merged 76 commits into from
May 10, 2024

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented May 6, 2024 •
edited
Loading

To be done in another PR

  • Loading states for NFT will rely on blur hash (needs BE)
  • Some properties will be dropped (icon/imageType) (maybe more)
  • Error states for NFT is missing
  • Gone state for NFT is missing
  • Handling 0 amounts in transfer is missing

stackchain added 30 commits May 4, 2024 12:53
@stackchain
chore(types): added SupportedNetworks
585d306
@stackchain
refactor(portfolio): refactor portfolio balance for pt
5005443
@stackchain
refactor(portfolio): disabling auto hydrate to avoid confunsion
216535f
@stackchain
reafactor(wallet-mobile): calc locked - to resolve without api
3efe8d7
@stackchain
chore(wallet-mobile): wip wiring up portoflio
3bc4d12
@stackchain
chore(common): helpers to deal with bigint
7161e4a
@stackchain
refactor(portfolio): refactor balance to amount
19fa578
@stackchain
chore(wallet-mobile): avoid some renders and dropping RNP slowly
bdbb3a3
@stackchain
chore(wallet-mobile): storage initialization / new types
19eacc7
@stackchain
chore(wallet-mobile): wip wire up
2dfda2c
@stackchain
chore(wallet-mobile): updated PairedBalance
3015ccb
@stackchain
chore(wallet-mobile): added helpers to handle info
85a80e4
@stackchain
chore(portfolio): added description
b4259a5
@stackchain
chore(portfolio): wip wire up
9d30546
@stackchain
chore(portfolio): wip wire up
9b8bc07
@stackchain
chore(portfolio): added clear function to balance manager
41bea04
@stackchain
chore(portfolio): added clear function to balance manager
a68578c
@stackchain
chore(wallet-mobile): sync pause and resume
ac00e4f
@stackchain
chore(transfer): adapted to portfolio amount
f436acf
@stackchain
chore(portfolio): moved info filter to portfolio
f36478d
@stackchain
chore(portfolio): added records type to balance manager
e3080ea
@stackchain
chore(portfolio): added isprimary helper
73a4a86
@stackchain
chore(transfer): moved helpers to transfer
889385c
@stackchain
chore(portfolio): refactor isprimary
e0ff1d4
@stackchain
chore(portfolio): exporting helpers
ef584b1
@stackchain
chore(portfolio): helpers renamed
1f0ace4
@stackchain
refactor(transfer): helpers
a347fab
@stackchain
fix(theme): added flowgen script
82d7c10
@stackchain
chore(transfer) changed the allocated behavior
1ec97fc
@stackchain
chore(portfolio): added more helpers
9cd45d5
@stackchain stackchain marked this pull request as ready for review May 8, 2024 15:52
@stackchain stackchain requested a review from banklesss May 9, 2024 09:08
@banklesss
Copy link
Contributor

Maybe it's a good opportunity to move the Nft related folders to the features folder?

michaeljscript
michaeljscript reviewed May 9, 2024
View reviewed changes
apps/wallet-mobile/src/NftDetails/NftDetails.stories.tsx Show resolved Hide resolved
apps/wallet-mobile/src/NftDetails/NftDetailsImage.tsx Show resolved Hide resolved
apps/wallet-mobile/src/NftDetails/NftDetailsImage.tsx Show resolved Hide resolved
apps/wallet-mobile/src/Search/SearchContext.tsx Show resolved Hide resolved
apps/wallet-mobile/src/TxHistory/AssetList/AssetList.tsx Show resolved Hide resolved
apps/wallet-mobile/src/TxHistory/AssetList/ListBalances.tsx Outdated Show resolved Hide resolved
apps/wallet-mobile/src/TxHistory/BalanceBanner.tsx Show resolved Hide resolved
apps/wallet-mobile/src/features/Portfolio/common/TokenAmountItem/TokenAmountItem.tsx Outdated Show resolved Hide resolved
...n/CreateOrder/EditSellAmount/SelectSellTokenFromListScreen/SelectSellTokenFromListScreen.tsx Outdated Show resolved Hide resolved
@stackchain stackchain merged commit f2621cf into develop May 10, 2024
2 checks passed
@stackchain stackchain deleted the chore/port-wire-up branch May 10, 2024 21:53
@stackchain stackchain mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljscript michaeljscript michaeljscript left review comments

@banklesss banklesss banklesss approved these changes

@SorinC6 SorinC6 Awaiting requested review from SorinC6

@jorbuedo jorbuedo Awaiting requested review from jorbuedo

Assignees

@stackchain stackchain

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stackchain @banklesss @michaeljscript