Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dapp-connector): Add CIP-30 support #3225

Merged
merged 57 commits into from
May 22, 2024
Merged

feat(dapp-connector): Add CIP-30 support #3225

merged 57 commits into from
May 22, 2024

Conversation

michaeljscript
Copy link
Collaborator

@michaeljscript michaeljscript commented Apr 30, 2024 •
edited
Loading

Resolves YOMO-1191

  • CIP30-getExtensions
  • CIP30-getNetworkId
  • CIP30-getUtxos
  • CIP30-getCollateral
  • CIP30-getBalance
  • CIP30-getUsedAddresses
  • CIP30-getUnusedAddresses
  • CIP30-getChangeAddress
  • CIP30-getRewardAddresses
  • CIP30-signTx
  • CIP30-submitTx
  • confirm connection modal
  • refactor (serialization, CSL, todos, utxos, translations, dapp-connector/src)
  • tests
  • revert project.pbxproj
  • add limit to 3 utxos in collateral

TX Flow will be finished in https://emurgo.atlassian.net/browse/YOMO-1198
HW support to be added in https://emurgo.atlassian.net/browse/YOMO-1442

@michaeljscript michaeljscript self-assigned this May 3, 2024
@michaeljscript
Copy link
Collaborator Author

michaeljscript commented May 20, 2024 •
edited
Loading

The signData may need changes in an external library and will be done in a different PR. See YOMO-1447

@michaeljscript michaeljscript changed the title feat(dapp-connector): Add CIP-30 support WIP: feat(dapp-connector): Add CIP-30 support May 21, 2024
@michaeljscript michaeljscript changed the title WIP: feat(dapp-connector): Add CIP-30 support feat(dapp-connector): Add CIP-30 support May 22, 2024
@michaeljscript
Copy link
Collaborator Author

@stackchain, that should be now all updated. Am I good to merge?

@stackchain stackchain merged commit 5d72fe9 into develop May 22, 2024
2 checks passed
@stackchain stackchain deleted the feat/dapp-cip-30 branch May 22, 2024 17:45
@stackchain stackchain mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackchain stackchain stackchain approved these changes

@jorbuedo jorbuedo jorbuedo approved these changes

Assignees

@michaeljscript michaeljscript

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeljscript @jorbuedo @stackchain