Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(pool-transition): Adds Pool transition modal and warnings #3184

Merged
merged 16 commits into from
Apr 22, 2024
Merged

feature(pool-transition): Adds Pool transition modal and warnings #3184

merged 16 commits into from
Apr 22, 2024

Conversation

jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Apr 8, 2024 •
edited
Loading

related:

Testing wallets are the production wallets, listed on https://github.com/Emurgo/yoroi-lib/blob/main/src/pools.ts#L42

TxHistory Settings Staking Center Failed
image image image image

Missing:

  • yoroi-lib update with PoolTransition and getPoolTransition

@jorbuedo jorbuedo added this to the 4.27.0 milestone Apr 8, 2024
@jorbuedo jorbuedo self-assigned this Apr 8, 2024
@jorbuedo jorbuedo marked this pull request as ready for review April 9, 2024 11:05
@jorbuedo
Copy link
Contributor Author

jorbuedo commented Apr 9, 2024

@stackchain Let me know if we want to have it on develop with the mock or block the PR till yoroi-lib is ready.

@jorbuedo jorbuedo removed this from the 4.27.0 milestone Apr 12, 2024
@stackchain stackchain added this to the 4.28.0 milestone Apr 12, 2024
@jorbuedo
Copy link
Contributor Author

@stackchain @michaeljscript @banklesss
Ready for merge on my side. 4.28.0 should get a regression to make sure the lib updates didn't break anything

stackchain
stackchain approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@stackchain stackchain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done but is blocked by the hardcoded date on the package, after merging a full regression will be required (swap create/cancel) due to CSL bump cc: @rahulnr7

@stackchain stackchain added the blocked Blocked label Apr 22, 2024
@stackchain
Copy link
Member

This is done but is blocked by the hardcoded date on the package, after merging a full regression will be required (swap create/cancel) due to CSL bump cc: @rahulnr7

Bringing it in, the package can be updated later.

@stackchain stackchain removed the blocked Blocked label Apr 22, 2024
@stackchain stackchain merged commit ac1bb6a into develop Apr 22, 2024
2 checks passed
@stackchain stackchain deleted the yomo-1272 branch April 22, 2024 09:32
jorbuedo added a commit that referenced this pull request Jun 10, 2024
@jorbuedo
feature(pool-transition): Adds Pool transition modal and warnings (#3184
52df775 
)
@stackchain stackchain mentioned this pull request Jun 10, 2024
Merged
14 tasks
@stackchain stackchain mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackchain stackchain stackchain approved these changes

@SorinC6 SorinC6 Awaiting requested review from SorinC6

@banklesss banklesss Awaiting requested review from banklesss

@michaeljscript michaeljscript Awaiting requested review from michaeljscript

@vsubhuman vsubhuman Awaiting requested review from vsubhuman

@pedromtcosta pedromtcosta Awaiting requested review from pedromtcosta

Assignees

@jorbuedo jorbuedo

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorbuedo @stackchain @michaeljscript @pedromtcosta