Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(receive): Change colors and title on wallet detail screen #3165

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

michaeljscript
Copy link
Collaborator

@michaeljscript michaeljscript commented Mar 25, 2024

Resolves YOMO-1260

@github-actions github-actions bot added the fix label Mar 25, 2024
@michaeljscript michaeljscript changed the title fix(address): Change colors and title on wallet detail screen fix(receive): Change colors and title on wallet detail screen Mar 25, 2024
@michaeljscript michaeljscript self-assigned this Mar 25, 2024
@michaeljscript michaeljscript added this to the 4.26.0 milestone Mar 25, 2024
@@ -1,6 +1,5 @@
import {useFocusEffect} from '@react-navigation/native'
import {useTheme} from '@yoroi/theme'
import _ from 'lodash'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did eslint think it was NOT an unused variable because it was named _? 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have a lot of these in the codebase 🤦‍♂️

@stackchain
Copy link
Member

stackchain commented Mar 25, 2024

@michaeljscript is it 4.26? ow yap

@stackchain stackchain merged commit dcfe8fa into develop Mar 25, 2024
2 checks passed
@stackchain stackchain deleted the fix/YOMO-1260 branch March 25, 2024 17:15
@michaeljscript
Copy link
Collaborator Author

@stackchain I had a chat with @rahulnr7 and this task was a priority, so I thought may be 4.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants