fix(swap): Hide cancelled orders with FE fee from completed orders #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljscript
commented
Mar 22, 2024
| @@ -77,6 +82,18 @@ const findCompletedOrderTx = (transactions: TransactionInfo[]): MappedRawOrder[] | |||
| return filteredTx.filter((tx) => tx.metadata !== null).sort(compareByDate) | |||
| } | |||
|
|
|||
| const hasFrontendFeeReturn = (tx: TransactionInfo): boolean => { | |||
| const addresses = tx.inputs.map((input) => input.address).filter(Boolean) | |||
There was a problem hiding this comment.
Should we normalize the address and ensure it's in bech32 format? Given it's bech32 now, do we need to expect it to change?
There was a problem hiding this comment.
I'd say this Address management needs a complete refactor, so not now
There was a problem hiding this comment.
@michaeljscript won't this hide cancelled orders with ffee?
There was a problem hiding this comment.
Hello @stackchain yes, it will hide cancelled orders in the completed orders tab, as is mentioned in the expected behaviour in the task
There was a problem hiding this comment.
ty @michaeljscript I missed that 🤦🏻
|
@stackchain @michaeljscript - checked the fix, looks good. |
rahulnr7
approved these changes
Mar 23, 2024
stackchain
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves YOMO-1264