fix(wallet-mobile): Status bar styles with hook and theme #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljscript
approved these changes
Mar 12, 2024
stackchain
reviewed
Mar 12, 2024
There was a problem hiding this comment.
I think this can be moved to /components/hooks/useStatusBar
stackchain
reviewed
Mar 12, 2024
| * @param color Hex color in #224466 format | ||
| * @returns Hex color halved #112233, same as if the modal backdrop was on top rgba(0,0,0,0.5) of it | ||
| */ | ||
| const opaqueColor = (color: HexColor) => { |
There was a problem hiding this comment.
can we have tests for this one
stackchain
reviewed
Mar 12, 2024
| @@ -0,0 +1,41 @@ | |||
| import {useFocusEffect} from '@react-navigation/native' | |||
| import {useTheme} from '@yoroi/theme' | |||
| import {useEffect} from 'react' | |||
There was a problem hiding this comment.
prefer non-default imports for better tree shaking + dependency check
stackchain
reviewed
Mar 12, 2024
| const color = baseColor ?? (isDark ? theme.color['black-static'] : theme.color['white-static']) | ||
| const bgColor = isOpen || legacyModal ? opaqueColor(color) : color | ||
|
|
||
| const effect = () => { |
stackchain
reviewed
Mar 12, 2024
| if (Platform.OS === 'android') StatusBarRN.setBackgroundColor(bgColor, true) | ||
| } | ||
| useFocusEffect(effect) | ||
| useEffect(effect, [bgColor, isDark, isOpen]) |
stackchain
reviewed
Mar 12, 2024
| ) | ||
| .join('')}` | ||
| } catch { | ||
| return color |
There was a problem hiding this comment.
avoid using error as logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://emurgo.atlassian.net/browse/YOMO-1231
I need someone to check iOS.
Legacy Blue in wallet selection
Primary color (100) in tx history
Light or Dark everywhere else
50% darker with a modal open
Additionally fixed some dark theme title header styles for tx history