refactor(exchange): extract params #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banklesss
commented
Mar 5, 2024
banklesss
commented
Mar 5, 2024
apps/wallet-mobile/src/features/RampOnOff/useCases/CreateExchange/CreateExchange.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: banklesss <105349292+banklesss@users.noreply.github.com>
michaeljscript
approved these changes
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
apps/wallet-mobile/src/features/RampOnOff/useCases/CreateExchange/CreateExchange.tsx
Outdated
Show resolved
Hide resolved
stackchain
reviewed
Mar 5, 2024
apps/wallet-mobile/src/features/RampOnOff/useCases/CreateExchange/CreateExchange.tsx
Outdated
Show resolved
Hide resolved
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
reviewed
Mar 5, 2024
stackchain
approved these changes
Mar 5, 2024
|
@banklesss please bump majors, for the package and whatever is using it. |
|
Changed to draft to update versions |
stackchain
reviewed
Mar 7, 2024
Signed-off-by: Juliano Lazzarotto <30806844+stackchain@users.noreply.github.com>
stackchain
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to YOMO-1223
NOTE: The refactor of returnUrl params, the update of docs and the restoration and fix of the exchange result screens will be done in this ticket https://emurgo.atlassian.net/browse/YOMO-1227