Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolver): update unstoppable supported tlds and manage errors #3026

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

banklesss
Copy link
Contributor

No description provided.

Copy link
Contributor

@jorbuedo jorbuedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love all the data used here.
If the API is returning an error message in the error response, why not use that as message? The statusText is superfluous anyway when you know the status code.

@banklesss
Copy link
Contributor Author

banklesss commented Jan 22, 2024

I don't love all the data used here.

If the API is returning an error message in the error response, why not use that as message? The statusText is superfluous anyway when you know the status code.

Message field in this case is undefined. The data is coming in the field data.

@stackchain stackchain added this to the 4.26.0 milestone Jan 22, 2024
@banklesss
Copy link
Contributor Author

banklesss commented Jan 22, 2024

Created this task to also change the field data from the fetchData success response after the current release.

https://emurgo.atlassian.net/browse/YOMO-1124

@stackchain
Copy link
Member

stackchain commented Jan 22, 2024

hey @banklesss I think you can apply it now, this only affects .com from UD, will only include it if another change is requested by Product after the UAT.
I mix up the comments

@stackchain
Copy link
Member

Created this task to also change the field data from the fetchData success response after the current release.

https://emurgo.atlassian.net/browse/YOMO-1124

Created this task to also change the field data from the fetchData success response after the current release.

https://emurgo.atlassian.net/browse/YOMO-1124

I think this is returning the axios object directly, if it is no need to refactor for now.

@stackchain
Copy link
Member

Created this task to also change the field data from the fetchData success response after the current release.
https://emurgo.atlassian.net/browse/YOMO-1124

Created this task to also change the field data from the fetchData success response after the current release.
https://emurgo.atlassian.net/browse/YOMO-1124

I think this is returning the axios object directly, if it is no need to refactor for now.

yap, it's remapping, keeping the task.

@stackchain stackchain merged commit 77855fa into develop Jan 22, 2024
2 checks passed
@stackchain stackchain deleted the fix/unstoppable-tld-list branch January 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants