-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resolver): update unstoppable supported tlds and manage errors #3026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love all the data
used here.
If the API is returning an error message in the error response, why not use that as message
? The statusText
is superfluous anyway when you know the status code.
Message field in this case is undefined. The data is coming in the field data. |
Created this task to also change the field |
|
I think this is returning the axios object directly, if it is no need to refactor for now. |
yap, it's remapping, keeping the task. |
No description provided.