fix(swap): removed price impact on limit orders #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
reviewed
Jan 16, 2024
| @@ -43,6 +46,7 @@ export const AmountItem = ({ | |||
| const formattedQuantity = Quantities.format(quantity, tokenInfo.decimals ?? 0) | |||
| const showSwapDetails = !isPrimary && variant === 'swap' | |||
| const priceImpactRiskTheme = usePriceImpactRiskTheme(priceImpactRisk ?? 'none') | |||
| const priceImpactRiskTextColor = orderType === 'market' ? priceImpactRiskTheme.text : styles.text.color | |||
There was a problem hiding this comment.
hey @SorinC6 just to confirm, so it won't hide, it will just display without emphasis in the color?
There was a problem hiding this comment.
I had a task before for when is a limit order to not display the Price Impact on the Confirm Transaction(summary) screen. As I see it if there is a limit order everything will be as usual and not show the price impact colors and warnings 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://emurgo.atlassian.net/browse/YOMO-1085