Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swap): price impact fmt and nmrlz precision #2960

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

stackchain
Copy link
Member

@stackchain stackchain commented Dec 27, 2023

  • Fixed the price formatting for the actualPrice -> price impact
  • Refactored for normalization Warn/Show use cases
  • Set the price precision to 10, some places were 14/10, exchanges use 10/12
  • Fixed the pool details to start expanded

Relates to: YOMO-1049

@github-actions github-actions bot added the fix label Dec 27, 2023
@@ -17,7 +17,7 @@ import {SwapInfoLink} from '../../../../common/SwapInfoLink/SwapInfoLink'

export const ShowPoolActions = () => {
const strings = useStrings()
const [hiddenInfoOpenId, setHiddenInfoOpenId] = React.useState<string | null>(null)
const [isExpanded, setIsExpanded] = React.useState(true)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pool details should start expanded now

@stackchain stackchain added this to the 4.25.0 milestone Dec 27, 2023
@stackchain stackchain marked this pull request as ready for review December 27, 2023 14:06
@stackchain stackchain merged commit ecd5dc9 into develop Dec 27, 2023
3 checks passed
@stackchain stackchain deleted the fix/price-impact-fmt-precision branch December 27, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants