feature: Use cdn for NFT images #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorbuedo
commented
Nov 9, 2023
•
 |
 |
 |
 |
|
Waiting for resize method to be added to the cdn |
|
Latest commit untested (preprod db is down) |
michaeljscript
approved these changes
Nov 20, 2023
stackchain
approved these changes
Nov 21, 2023
stackchain
reviewed
Nov 21, 2023
| queryKey: ['native-asset-img', policy, name, `${width}x${height}`, resizeMode], | ||
| queryFn: async () => { | ||
| const response = await fetch( | ||
| `https://${network}.cardano-nativeassets-prod.emurgornd.com/${policy}/${name}?width=${width}&height=${height}&kind=${kind}&fit=${resizeMode}`, |
There was a problem hiding this comment.
TODO:
- Move to the wallet api interface
.getTokenImage
|
@stackchain Ready to merge from my side |
I think on FE is done, still some images are not going through the CDN, holding for a bit while BE figures it out. |
stackchain
reviewed
Dec 11, 2023
stackchain
reviewed
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.