feat(staking): Add staking package with governance feature #2874
Conversation
|
|
||
| it('should throw an error when for a DRep id that has wrong length', async () => { | ||
| const invalidId = 'abc' | ||
| const errorMessage = 'invalid DRep ID length, must be 56 characters' |
There was a problem hiding this comment.
so it's just the hash no bech32 ? (I'd say the client api should receive both and we transform before consuming the api)
There was a problem hiding this comment.
Good point, will add this as well
There was a problem hiding this comment.
This will need to be updated in https://github.com/Emurgo/cardano-serialization-lib/blob/5c58e5ee75b0d6262840287ba06c9f9d1caf1037/rust/src/chain_crypto/bech32.rs#L63, because we're getting a parse error Parsed bech32 has invalid HRP prefix 'drep', expected 'xpub'
There was a problem hiding this comment.
Checking with Ahmed and Evgenii
There was a problem hiding this comment.
I'll be updating cross-csl
There was a problem hiding this comment.
This will be updated in a new PR for YOMO-1002
|
2 items WIP, check description |
|
1 item WIP, I'll update cross-csl to enable DREP.fromBech32 to improve validation used in this package |
|
Note the base branch is now |
Resolves YOMO-955