Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: domain resolver #2866

Merged
merged 66 commits into from
Dec 19, 2023
Merged

feature: domain resolver #2866

merged 66 commits into from
Dec 19, 2023

Conversation

banklesss
Copy link
Contributor

@banklesss banklesss commented Nov 1, 2023 •
edited by stackchain
Loading

Working with unstoppable and $handle domains at the moment

Related to YOMO-898

TODO:

  • add test
  • add proper typing
  • refactor folder structure
  • add cns resolver
  • add $handle resolver
  • add unstoppable domains resolver
  • use fetcher instead of axios directly
  • improve error management
  • UI update
  • React Context Provider
  • Initial message storage API
  • preprod support

@banklesss banklesss self-assigned this Nov 1, 2023
banklesss and others added 17 commits November 1, 2023 19:48
@banklesss
feature(resolver): fisrt functional poc
df442cb
@banklesss
Merge branch 'develop' into feature/resolver
5796b9c 
Signed-off-by: banklesss <105349292+banklesss@users.noreply.github.com>
@banklesss
Merge remote-tracking branch 'origin/develop' into feature/resolver
d37b35a
@banklesss
Merge remote-tracking branch 'origin/develop' into feature/resolver
41584d3
@banklesss
refactor: resolver
355fec2
@banklesss
Merge remote-tracking branch 'origin/develop' into feature/resolver
2f80532
@banklesss
feat(resolver): ongoing refactor
77c78ff
@banklesss
Merge remote-tracking branch 'origin/develop' into feature/resolver
7d0b05a
@banklesss
feat(resolver): adding proper typing and soppable service
efb3c3a
@banklesss
Merge branch 'develop' into feature/resolver
83cb7e0
@banklesss
feat(resolver): adding proper typing and soppable service
aa571a7
@banklesss
refactor(resolver) form input
b01b7d2
@banklesss
feature(resolver): add error management
896ceab
@banklesss
feature(resolver): add error management
ab7659d
@banklesss
feature(resolver): add error management
33c4cad
@banklesss
feature(resolver): add error management
09c4cd4
@banklesss
feature(resolver): add error management
ea2f87d
@banklesss banklesss requested a review from stackchain November 17, 2023 12:26
stackchain
stackchain reviewed Dec 18, 2023
View reviewed changes
apps/wallet-mobile/src/yoroi-wallets/cardano/constants/common.ts
@@ -54,7 +54,7 @@ export const LINEAR_FEE = {
} as const
export const MINIMUM_UTXO_VAL = '1000000'

export const HISTORY_REFRESH_TIME = 25000
export const HISTORY_REFRESH_TIME = 35000
Copy link
Member

@stackchain stackchain Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avg block is ~20s, doing below 30s has a high chance to sync with no updates, ideal 30/worst 40/avg 35s. (suggesting to add as a config) for the user

stackchain
stackchain reviewed Dec 18, 2023
View reviewed changes
apps/wallet-mobile/src/yoroi-wallets/hooks/index.ts
@@ -742,7 +742,7 @@ export const useIsOnline = (
() => true,
() => false,
),
refetchInterval: 5000,
refetchInterval: 15000,
Copy link
Member

@stackchain stackchain Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too often, under a block is fine avg 20s

stackchain
stackchain reviewed Dec 18, 2023
View reviewed changes
packages/resolver/src/adapters/cns.ts
if (!receiver.includes('.')) throw new Resolver.Errors.InvalidDomain()
if (!isCnsDomain(receiver))
return Promise.reject(new Resolver.Errors.UnsupportedTld())
return Promise.reject(new Resolver.Errors.UnsupportedTld())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsupported for now, needs implementation.

stackchain
stackchain reviewed Dec 18, 2023
View reviewed changes
packages/resolver/src/adapters/handle-api.ts
// ultra_rare = 'ultra_rare', // - 2 characters
// legendary = 'legendary' // - 1 character
// }
rarity: string // translated to string only
Copy link
Member

@stackchain stackchain Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rarity on handle API is an enum, we translate it to string for now.

stackchain
stackchain reviewed Dec 18, 2023
View reviewed changes
packages/types/src/resolver/receiver.ts
@@ -0,0 +1,8 @@
import {ResolverNameServer} from './service'

export type ResolverReceiver = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

receiver is no longer a string and becomes a new data structure,
resolve => domain/address/receiver to use/resolve aka URL
as => type, domain means supported domain
selectedNameServer defaults to the only response if === 1 aka NS
addressRecords the list of addresses per name server aka A record

@stackchain stackchain marked this pull request as ready for review December 18, 2023 14:06
@stackchain stackchain added feature and removed blocked Blocked labels Dec 18, 2023
@stackchain stackchain added this to the 4.25.0 milestone Dec 18, 2023
michaeljscript
michaeljscript approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@michaeljscript michaeljscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and works well!

banklesss
banklesss commented Dec 18, 2023
View reviewed changes
packages/resolver/src/adapters/handle-api.ts
import {Api, Resolver} from '@yoroi/types'
import {fetchData, FetchData, handleApiError, isLeft} from '@yoroi/common'
import {z} from 'zod'
import {AxiosRequestConfig} from 'axios'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be wrapped in @yoroi/common?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yap, is a little bit leaky since is exposing the "fetcher" config directly, but also didn't want a 1:1, it's a @banklesss good call for an improvement, maybe we can expose only what we are actually using.

stackchain and others added 3 commits December 19, 2023 09:54
@stackchain
merge: develop
89491bf
@stackchain
fix: merge
d0ddbd8
@stackchain @banklesss
Update packages/resolver/src/adapters/handle-api.ts
654f33b 
Co-authored-by: banklesss <105349292+banklesss@users.noreply.github.com>
Signed-off-by: Juliano Lazzarotto <30806844+stackchain@users.noreply.github.com>
banklesss
banklesss commented Dec 19, 2023
View reviewed changes
apps/wallet-mobile/src/components/TextInput/TextInput.tsx
@@ -18,7 +19,7 @@ export type TextInputProps = RNTextInputProps &
Omit<React.ComponentProps<typeof RNPTextInput>, 'theme'> & {
containerStyle?: ViewStyle
renderComponentStyle?: ViewStyle
helperText?: string
helper?: string | React.ReactNode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
helper?: string | React.ReactNode
helper?: React.ReactNode

@stackchain stackchain merged commit 644f5c2 into develop Dec 19, 2023
2 checks passed
@stackchain stackchain deleted the feature/resolver branch December 19, 2023 10:04
SorinC6 pushed a commit that referenced this pull request Jan 9, 2024
@banklesss @stackchain @SorinC6
feature: domain resolver (#2866)
9027fb9 
Signed-off-by: banklesss <105349292+banklesss@users.noreply.github.com>
Signed-off-by: Juliano Lazzarotto <30806844+stackchain@users.noreply.github.com>
Co-authored-by: Juliano Lazzarotto <30806844+stackchain@users.noreply.github.com>
@stackchain stackchain mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljscript michaeljscript michaeljscript approved these changes

@jorbuedo jorbuedo Awaiting requested review from jorbuedo

@SorinC6 SorinC6 Awaiting requested review from SorinC6

@stackchain stackchain Awaiting requested review from stackchain

Assignees

@banklesss banklesss

Labels
feature
Projects
None yet
Milestone
4.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@banklesss @michaeljscript @stackchain