fix(resolver): wrong blockchain error (#3037)

Signed-off-by: banklesss <105349292+banklesss@users.noreply.github.com>
Emurgo · Jan 24, 2024 · 910b52b · 910b52b
1 parent f5e0306
commit 910b52b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/packages/resolver/src/adapters/unstoppable/api.test.ts b/packages/resolver/src/adapters/unstoppable/api.test.ts
@@ -211,7 +211,7 @@ describe('getCryptoAddress', () => {
     })
 
     await expect(() => getCryptoAddress(domain)).rejects.toThrow(
-      Resolver.Errors.NotFound,
+      Resolver.Errors.WrongBlockchain,
     )
     expect(mockFetchData).toHaveBeenCalledWith(
       {
@@ -225,7 +225,7 @@ describe('getCryptoAddress', () => {
     )
   })
 
-  it('should throw invalid blockchain if the response contain the address for other blockchain', async () => {
+  it('should throw wrong blockchain if the response contain the address for other blockchain', async () => {
     const domain = mockApiResponse.meta.domain
     const expectedUrl = `${unstoppableApiConfig.mainnet.getCryptoAddress}${domain}`
     const invalidApiResponse = {

diff --git a/packages/resolver/src/adapters/unstoppable/api.ts b/packages/resolver/src/adapters/unstoppable/api.ts
@@ -40,28 +40,23 @@ export const unstoppableApiGetCryptoAddress = (
 
         handleApiError(error)
       } else {
+        // parsing
         const safeParsedAdaResponse = UnstoppableApiAdaResponseSchema.safeParse(
           response.value.data,
         )
         const safeParsedGeneralResponse =
           UnstoppableApiGeneralResponseSchema.safeParse(response.value.data)
 
+        // checking
         const hasCardanoAddress = safeParsedAdaResponse.success
-        const hasOtherBlockchainAddress =
-          !hasCardanoAddress &&
-          safeParsedGeneralResponse.success &&
-          Object.keys(response.value.data.records).length > 0
-        const hasNotAnyAddress =
-          !hasOtherBlockchainAddress && safeParsedGeneralResponse.success
+        const hasOtherBlockchainAddress = safeParsedGeneralResponse.success
 
         if (hasCardanoAddress)
           return response.value.data.records['crypto.ADA.address']
 
         if (hasOtherBlockchainAddress)
           throw new Resolver.Errors.WrongBlockchain()
 
-        if (hasNotAnyAddress) throw new Resolver.Errors.NotFound()
-
         throw new Resolver.Errors.InvalidResponse()
       }
     } catch (error: unknown) {
@@ -104,10 +99,13 @@ const UnstoppableApiAdaResponseSchema = z.object({
 })
 
 const UnstoppableApiGeneralResponseSchema = z.object({
+  meta: z.object({
+    blockchain: z.string(),
+  }),
   records: z.record(z.string(), z.string()),
 })
 
-// https://docs.unstoppabledomains.com/openapi/resolution/
+// curl https://api.unstoppabledomains.com/resolve/supported_tlds
 export const unstoppableSupportedTlds = [
   '.x',
   '.polygon',
@@ -125,6 +123,8 @@ export const unstoppableSupportedTlds = [
   '.anime',
   '.manga',
   '.go',
+  '.altimist',
+  '.unstoppable',
   '.zil',
   '.eth',
 ] as const

diff --git a/packages/resolver/src/utils/isResolvableDomain.test.ts b/packages/resolver/src/utils/isResolvableDomain.test.ts
@@ -23,8 +23,8 @@ describe('isResolvableDomain', () => {
     ${'ud.eth'}         | ${true}
     ${'$adahandle'}     | ${true}
     ${'cns.ada'}        | ${true}
+    ${'ud.unstoppable'} | ${true}
     ${'ud.com'}         | ${false}
-    ${'ud.unstoppable'} | ${false}
     ${'other.uk'}       | ${false}
     ${'$'}              | ${false}
   `('should return $expected for $resolve', ({resolve, expected}) => {