Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75 update to bevy 013 #76

Merged
merged 16 commits into from
Feb 27, 2024
Merged

75 update to bevy 013 #76

merged 16 commits into from
Feb 27, 2024

Conversation

EmiOnGit
Copy link
Owner

Todo:

@EmiOnGit EmiOnGit linked an issue Feb 20, 2024 that may be closed by this pull request
@janhohenheim
Copy link
Collaborator

janhohenheim commented Feb 26, 2024

@EmiOnGit FYI, I'm testing this branch on Foxtrot right now and I'm getting this crash:
image

@EmiOnGit
Copy link
Owner Author

Yes, they mistakenly removed the visibility of the globals in the vertex shader.
Was readded here bevyengine/bevy#12032 and should be contained in the 0.13.1 update.
I've been trying to work around that for 0.13 but to no avail so far.

@EmiOnGit EmiOnGit marked this pull request as ready for review February 27, 2024 17:42
@EmiOnGit
Copy link
Owner Author

@janhohenheim I have migrated everything now. Do you mind testing it on foxtrot again? If everything is alright on your side, I'll publish

@janhohenheim
Copy link
Collaborator

Sure! I'll check in about 2 hours :)

@janhohenheim
Copy link
Collaborator

janhohenheim commented Feb 27, 2024

@EmiOnGit works like a charm, good job! ❤️

@EmiOnGit
Copy link
Owner Author

Thanks for testing! :)

@EmiOnGit EmiOnGit merged commit 56d2102 into main Feb 27, 2024
@EmiOnGit EmiOnGit deleted the 75-update-to-bevy-013 branch February 27, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Bevy 0.13
2 participants