Remove copies of FindMPI and FindOpenMP CMake modules. #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These modules have been copied from a (very) old version of CMake (probably a long time ago). The minimum CMake required version has been bumped to 3.10 recently which include these modules. Additionally, the existing copy of the (old) FindOpenMP CMake module is incompatible with the CMake import targets used by newer versions of SuiteSparse libraries (CHOLMOD and UMFPACK). (That is only important when trying to use non-bundled versions of those libraries.) Just remove the two modules that are no longer needed plus their dependencies (since they are supplied by CMake itself) and only cause issues.
|
Indeed, this seems to work without both with MPI and OpenMP at least on my Ubuntu. Thanx for contributing! The built system rarely gets the needed attention. Just running on other platforms and will merge if tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modules have been copied from a (very) old version of CMake (probably a long time ago). The minimum CMake required version has been bumped to 3.10 recently which include these modules.
Additionally, the existing copy of the (old) FindOpenMP CMake module is incompatible with the CMake import targets used by newer versions of SuiteSparse libraries (CHOLMOD and UMFPACK). (That is only important when trying to use non-bundled versions of those libraries.)
Just remove the two modules that are no longer needed plus their dependencies (since they are supplied by CMake itself) and only cause issues.