Update HF conversion docs following reversion of is_pipe_parallel check
#959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #866 the default conversion script for v2.0 should now be the former
convert_v1.0_to_hf.py, since for pipe-parallel-size>=1 models are now saved as PipelineModules rather than nn.Sequential by default.This PR updates the name of
convert_v1.0_to_hf.pytoconvert_module_to_hf.pyto indicate this more general usage, and updates the docs in line with this (as well as explicitly describing the situations in which the sequential conversion script should be used).