Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elip_liquidex module #207

Merged

Conversation

LeoComandini
Copy link
Contributor

Use "liquidex" field for the asset blinding factor.

Related ELIP: ElementsProject/ELIPs#18

Copy link
Collaborator

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2a5d6af test match proposed elip

use crate::encode::{serialize_hex, Encodable};
use crate::hex::{FromHex, ToHex};

const ELIP0XXX_IDENTIFIER: &str = "fc0d707365745f6c6971756964657800";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth mentioning is ~ "pset_liquidex"/PSET_LIQUIDEX_PREFIX in hex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, also the last "00" were extra

@LeoComandini LeoComandini force-pushed the 2024-07-elip-liquidex branch from 2a5d6af to 7737c82 Compare July 29, 2024 13:00
@RCasatta
Copy link
Collaborator

ACK 7737c82

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7737c82 successfully ran local tests

@apoelstra apoelstra merged commit 25dc2d2 into ElementsProject:master Aug 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants