Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offers: Not just for breakfast anymore! #7833

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Offers: Not just for breakfast anymore! #7833

merged 5 commits into from
Nov 18, 2024

Conversation

rustyrussell
Copy link
Contributor

Normally, I'd wait until we did a BOLT update next release, but let's be bold!

@rustyrussell
offers: make it the default.
9d2c6b9 
Changelog-Changed: offers: bolt12 now enabled by default (finally!)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
docs: no longer tell people experimental-offers is required.
e49a206 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
plugins: don't check for experimental-offers option: it's the default…
ef1711a 
… now.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
pytest: don't set experimental-offers in tests: it's the default now.
728b905 
And about to be deprecated.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added this to the v24.11 milestone Nov 18, 2024
@rustyrussell
lightningd: deprecate experimental-offers option.
af8a88a 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Deprecated: Config: `experimental-offers` (it's now the default).
@rustyrussell rustyrussell force-pushed the guilt/offers-not-experimental branch from ef47762 to af8a88a Compare November 18, 2024 05:19
vincenzopalazzo
vincenzopalazzo approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK af8a88a

Yes please!

@vincenzopalazzo
Copy link
Contributor 

test_channel_receivable passed 1 out of the required 1 times. Success!

===End Flaky Test Report===
=========================== short test summary info ============================
FAILED tests/test_misc.py::test_restorefrompeer - AssertionError: assert 'FUNDING_SPEND_SEEN' == 'ONCHAIN'
  - ONCHAIN
  + FUNDING_SPEND_SEEN
============= 1 failed, 73 passed, 8 skipped in 1769.37s (0:29:29) =============

CI is finding the following failure, probably we should wait a little bit longer

@vincenzopalazzo vincenzopalazzo mentioned this pull request Nov 18, 2024
Open
@vincenzopalazzo
Copy link
Contributor

Mergin this while tracking the flaky test #7837

@vincenzopalazzo vincenzopalazzo merged commit 1b41350 into ElementsProject:master Nov 18, 2024
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

@cdecker cdecker Awaiting requested review from cdecker cdecker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v24.11
Development

Successfully merging this pull request may close these issues.
2 participants
@rustyrussell @vincenzopalazzo