Sql plugin crash fix #7578
Merged
Sql plugin crash fix #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inside it.
There's only one place (added in v24.02) where we have nested subobjects, and
if the outer sub-object is not there it crashes.
```
sql: FATAL SIGNAL 11 (version v24.08rc1-2-ge134f2f-modded)
0x5781d447239b send_backtrace
common/daemon.c:33
0x5781d4472432 crashdump
common/daemon.c:75
0x787bcd64531f ???
./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x5781d447782a json_get_membern
common/json_parse_simple.c:210
0x5781d44778cc json_get_member
common/json_parse_simple.c:223
0x5781d445d0e2 process_json_obj
plugins/sql.c:537
0x5781d445d10d process_json_obj
plugins/sql.c:538
0x5781d445d598 process_json_list
plugins/sql.c:684
0x5781d445d65a process_json_result
plugins/sql.c:699
0x5781d445d7cb default_list_done
plugins/sql.c:722
0x5781d446349d handle_rpc_reply
plugins/libplugin.c:1016
0x5781d4463640 rpc_read_response_one
plugins/libplugin.c:1202
0x5781d44636f1 rpc_conn_read_response
plugins/libplugin.c:1226
0x5781d459e56c next_plan
ccan/ccan/io/io.c:60
0x5781d459ea3d do_plan
ccan/ccan/io/io.c:422
0x5781d459eafa io_ready
ccan/ccan/io/io.c:439
0x5781d45a0469 io_loop
ccan/ccan/io/poll.c:455
0x5781d4463dcb plugin_main
plugins/libplugin.c:2230
```
Changelog-Fixed: Plugins: `sql` crash on querying `listpeerchannels` during channel establishment.
Fixes: ElementsProject#7505
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Inside listpeerchannels, there's an object called `updates`, and inside that objects `local` and `remote`. We flatten this, but the documentation doesn't mention the `updates` field at all.
Ideally we would rename these fields to include `updates_` but that would be a breaking change.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
```
- `row` (reference to `peerchannels_channel_type.rowid`, sqltype `INTEGER`)
- `arrindex` (index within array, sqltype `INTEGER`)
- `names` (type `string`, sqltype `TEXT`)
- - `local_htlc_minimum_msat` (type `msat`, sqltype `INTEGER`, from JSON object `local`)
- - `local_htlc_maximum_msat` (type `msat`, sqltype `INTEGER`, from JSON object `local`)
- - `local_cltv_expiry_delta` (type `u32`, sqltype `INTEGER`, from JSON object `local`)
- - `local_fee_base_msat` (type `msat`, sqltype `INTEGER`, from JSON object `local`)
- - `local_fee_proportional_millionths` (type `u32`, sqltype `INTEGER`, from JSON object `local`)
- - `remote_htlc_minimum_msat` (type `msat`, sqltype `INTEGER`, from JSON object `remote`)
- - `remote_htlc_maximum_msat` (type `msat`, sqltype `INTEGER`, from JSON object `remote`)
- - `remote_cltv_expiry_delta` (type `u32`, sqltype `INTEGER`, from JSON object `remote`)
- - `remote_fee_base_msat` (type `msat`, sqltype `INTEGER`, from JSON object `remote`)
- - `remote_fee_proportional_millionths` (type `u32`, sqltype `INTEGER`, from JSON object `remote`)
+ - `local_htlc_minimum_msat` (type `msat`, sqltype `INTEGER`, from JSON object `updates.local`)
+ - `local_htlc_maximum_msat` (type `msat`, sqltype `INTEGER`, from JSON object `updates.local`)
+ - `local_cltv_expiry_delta` (type `u32`, sqltype `INTEGER`, from JSON object `updates.local`)
+ - `local_fee_base_msat` (type `msat`, sqltype `INTEGER`, from JSON object `updates.local`)
+ - `local_fee_proportional_millionths` (type `u32`, sqltype `INTEGER`, from JSON object `updates.local`)
+ - `remote_htlc_minimum_msat` (type `msat`, sqltype `INTEGER`, from JSON object `updates.remote`)
+ - `remote_htlc_maximum_msat` (type `msat`, sqltype `INTEGER`, from JSON object `updates.remote`)
+ - `remote_cltv_expiry_delta` (type `u32`, sqltype `INTEGER`, from JSON object `updates.remote`)
+ - `remote_fee_base_msat` (type `msat`, sqltype `INTEGER`, from JSON object `updates.remote`)
+ - `remote_fee_proportional_millionths` (type `u32`, sqltype `INTEGER`, from JSON object `updates.remote`)
- `ignore_fee_limits` (type `boolean`, sqltype `INTEGER`)
- `lost_state` (type `boolean`, sqltype `INTEGER`)
- `feerate_perkw` (type `u32`, sqltype `INTEGER`, from JSON object `feerate`)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when there is a missing object which has subobjects (only happens in one place, listpeerchannels on unfinished channel which doesn't have an
updatesobject yet).Fixes: #7505