Part 1: offers cleanups #7454
Merged
Part 1: offers cleanups #7454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We did since v23.05. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This can't happen because we go the self-pay path in this case, but once we fix that for bolt12, this can be reached. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It doesn't work but at least now it doesn't crash! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This was when we handled pre-TLV onions where the first byte was 0. We haven't done that for a while: you can tell, because process_onionpacket doesn't use the parameter at all! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We don't use the payment_secret in bolt12, but in onion_decode() we do put the path_secret (if of correct length) into payment_secret. Not realizing this confused me, so document that, and make sure we insist on it being present for bolt12. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I noticed we were missing this. Move logging up a level so it's easier to spot the omission. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Only sphinx internally uses the hmac field: it's actually a general descriptor of onion contents, which we can use elsewhere. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
A second user is coming. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…r connect_disable. It's always the same string, so simplify the interface. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Document and enforce the --experimental-anchors deprecation, which was somehow missed in v24.02 Changelog-Deprecated: Config: the --experimental-anchors option is ignored (on by default since v24.02).
We never call `listconfigs` in our tests with `experimental-offers` enabled, so we didn't notice that the schema is wrong: it does not expect the "plugin" field in 'fetchinvoice-noconnect'. The next patch folds the fetchinvoice plugin into the offers plugin, which is enabled even if `experimental-offers` isn't (for `decode`), so we notice it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
a8eaedc to
1fb6cb3
Compare
|
Trivial rebase on master, for flake fix. |
7f71e63
into
ElementsProject:master
31 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In updating and enhancing bolt12 to be a production-quality implementation, I found these miscellaneous nits which needed fixing.