offers: Update to include sciddir_or_pubkey, for introduction point in blinded path. #7212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
901167f to
30afcd1
Compare
There was a problem hiding this comment.
======================== 1 passed, 3 warnings in 6.78s =========================
make[1]: Leaving directory '/home/runner/work/lightning/lightning/contrib/pyln-testing'
common/sciddir_or_pubkey.c:1: includes out of order
#include "config.h"
#include <assert.h>
#include <common/sciddir_or_pubkey.h>
#include <common/node_id.h>
#include <wire/wire.h>
VERSUS
#include "config.h"
#include <assert.h>
#include <common/node_id.h>
#include <common/sciddir_or_pubkey.h>
#include <wire/wire.h>
rm external/build-x86_64-linux-gnu/libwally-core-build/src/secp256k1/libsecp256k1.la
make: *** [Makefile:477: check-src-include-order/common/sciddir_or_pubkey.c] Error 1
445a82d to
1539ea1
Compare
1539ea1 to
8c9579d
Compare
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is proposed to be added to bolt 12, so we need a type to represent it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… plugin. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…we're the only user. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's fairly obscure, and let's not make everyone link it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We don't actually support it yet, but this threads through the type change, puts it in "decode" etc. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8c9579d to
12e3965
Compare
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: offers: we now understand blinded paths which use a short-channel-id(+direction) as entry point.
Print the first_node_id field, and do it all on one line per path. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
12e3965 to
f6e5a6c
Compare
vincenzopalazzo
approved these changes
May 9, 2024
| @@ -1761,12 +1761,14 @@ static void payment_add_blindedpath(const tal_t *ctx, | |||
| const u8 *cursor = tlvs[i]; | |||
| size_t max = tal_bytelen(tlvs[i]); | |||
| /* First one has to use real node_id */ | |||
There was a problem hiding this comment.
This comment is now a bit ambiguous. Maybe "entry node cannot be blinded"?
| "first_scid": { | ||
| "added": "v23.05", | ||
| "type": "short_channel_id", | ||
| "description": "the short channel id of the start of the path (alternative to first_n ode_id)" |
There was a problem hiding this comment.
Suggested change
| "description": "the short channel id of the start of the path (alternative to first_n ode_id)" | |
| "description": "the short channel id of the start of the path (alternative to first_node_id)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out to be pretty easy to use, once we do all the plumbing (and some simplification along the way!)