Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splice-out Regression and Restart Fixes #6677

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Splice-out Regression and Restart Fixes #6677

merged 1 commit into from
Sep 21, 2023

Conversation

ddustin
Copy link
Collaborator

@ddustin ddustin commented Sep 13, 2023 •
edited
Loading

Ran a test for splicing out that exposed some behavior and code glitches that are addressed in this PR.

Added test for splice gossip.

Also added documentation for how to do a splice out.

Fixes #6658
Fixes #6656
Fixes #6613
Fixes #6612

Fixes #6572
Fixes #6481

@ddustin ddustin added this to the v23.08 Point Releases milestone Sep 13, 2023
@ddustin ddustin requested a review from cdecker as a code owner September 13, 2023 23:46
@ddustin ddustin mentioned this pull request Sep 13, 2023
Closed
@ddustin ddustin force-pushed the ddustin/splice_out_test branch 8 times, most recently from 853e299 to d4f90f6 Compare September 15, 2023 00:10
@ddustin ddustin changed the title Splice Out Regression Test & Fixes Splice-out Regression and Restart Fixes Sep 15, 2023
@ddustin ddustin force-pushed the ddustin/splice_out_test branch 4 times, most recently from 30d534f to 5fa1e16 Compare September 19, 2023 18:33
This was referenced Sep 19, 2023
Closed
Closed
@ddustin ddustin force-pushed the ddustin/splice_out_test branch 2 times, most recently from dbe0e15 to 64a26df Compare September 19, 2023 22:00
@rustyrussell
Copy link
Contributor

OK, you need to split the "fix" commit off from the "add test" commit. If we do another point release, we'll include the fix commit, but not the test one...

@ddustin ddustin force-pushed the ddustin/splice_out_test branch 2 times, most recently from b838308 to 0530ffb Compare September 20, 2023 19:50
@ddustin ddustin mentioned this pull request Sep 20, 2023
Closed
3 tasks
@ddustin ddustin force-pushed the ddustin/splice_out_test branch from 0530ffb to 54dbc5c Compare September 21, 2023 02:27
@ddustin
Copy link
Collaborator Author

ddustin commented Sep 21, 2023

OK, you need to split the "fix" commit off from the "add test" commit. If we do another point release, we'll include the fix commit, but not the test one...

Moved the tests out and put them in #6676 for now

@ddustin ddustin mentioned this pull request Sep 21, 2023
Closed
@ddustin
splice: Fixes from splice-out test
39da2f4 
Added a test for splicing out that exposed some behavior and code glitches that are addressed in this commit.

Added test for splice gossip.

Also added documentation for how to do a splice out.

ChangeLog-Fixed: Added docs, testing, and some fixes related to splicing out, insufficent balance handling, and restarting during a splice.
@ddustin ddustin force-pushed the ddustin/splice_out_test branch from 54dbc5c to 39da2f4 Compare September 21, 2023 02:51
@ddustin ddustin mentioned this pull request Sep 21, 2023
Merged
@rustyrussell rustyrussell merged commit 0a5ef7f into ElementsProject:master Sep 21, 2023
@rustyrussell
Copy link
Contributor

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustyrussell rustyrussell Awaiting requested review from rustyrussell

@cdecker cdecker Awaiting requested review from cdecker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v23.08 Point Releases
2 participants
@ddustin @rustyrussell