Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin clnrest #6389

Merged
merged 9 commits into from
Jul 25, 2023
Merged

Plugin clnrest #6389

merged 9 commits into from
Jul 25, 2023

Conversation

rustyrussell
Copy link
Contributor

Was #6369

@rustyrussell rustyrussell added this to the v23.08 milestone Jul 7, 2023
vincenzopalazzo
vincenzopalazzo previously requested changes Jul 8, 2023
View reviewed changes
plugins/clnrest/utilities/rpc_routes.py Outdated Show resolved Hide resolved
plugins/clnrest/utilities/rpc_routes.py Outdated Show resolved Hide resolved
plugins/clnrest/utilities/rpc_plugin.py Outdated Show resolved Hide resolved
cdecker
cdecker reviewed Jul 12, 2023
View reviewed changes
plugins/clnrest/README.md Outdated Show resolved Hide resolved
cdecker
cdecker reviewed Jul 12, 2023
View reviewed changes
plugins/clnrest/README.md Show resolved Hide resolved
plugins/clnrest/utilities/rpc_routes.py Outdated Show resolved Hide resolved
@rustyrussell rustyrussell force-pushed the plugin-clnrest branch 3 times, most recently from e470761 to 957961b Compare July 15, 2023 04:43
@ShahanaFarooqui ShahanaFarooqui dismissed vincenzopalazzo’s stale review July 18, 2023 02:25

Removed notification. I will open another PR with Websocket Server.

@vincenzopalazzo vincenzopalazzo mentioned this pull request Jul 21, 2023
Open
@ShahanaFarooqui ShahanaFarooqui force-pushed the plugin-clnrest branch 2 times, most recently from c137bdc to cbac136 Compare July 25, 2023 00:46
ShahanaFarooqui and others added 4 commits July 24, 2023 18:40
@ShahanaFarooqui
plugin: clnrest
e0b64b7 
plugin: clnrest
@rustyrussell @ShahanaFarooqui
doc: update installation to not refer to PPA, and indicate how to get…
e5bd427 
… clnrest support.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell @ShahanaFarooqui
plugins/clnrest: fail gracefully if dependencies not installed.
8daa10f 
json and sys are Python built-in packages, so we can do this.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell @ShahanaFarooqui
lightningd: if a plugin disables at getmanfest time, use INFO log level.
607de78 
This gets printed by default, so it's not lost!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@ShahanaFarooqui ShahanaFarooqui force-pushed the plugin-clnrest branch 2 times, most recently from 3d73329 to 4d71371 Compare July 25, 2023 04:52
@rustyrussell
Copy link
Contributor Author

Ack 4d71371

@rustyrussell rustyrussell self-assigned this Jul 25, 2023
ShahanaFarooqui and others added 4 commits July 25, 2023 17:46
@ShahanaFarooqui @rustyrussell
plugin: On-boarding default python plugins
3182732 
plugin: On-boarding default python plugins
@rustyrussell
plugins/clnrest: disable ourselves unless rest-port is set.
186f641 
This mirrors grpc's behavior, and avoids listening on ports without
explicit user permission.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@ShahanaFarooqui @rustyrussell
plugins/clnrest: removing notifications queue in favor of websocket s…
d46b2d7 
…erver
@ShahanaFarooqui @rustyrussell
plugins/clnrest: Update clnrest dependencies in scripts and Dockerfiles
ad244a2 
Adding python3-json5 python3-flask python3-gunicorn flask_restx pyln-client
Also run `pip3 install -r plugins/clnrest/requirements.txt`
@ShahanaFarooqui @rustyrussell
plugins/clnrest: Websocket Server
02c2d8a 
- Added Dependencies
- Updated WS client instructions
- WS Server
@rustyrussell
Copy link
Contributor Author

Fixed uninstall make target...

@rustyrussell rustyrussell merged commit 911d2c1 into ElementsProject:master Jul 25, 2023
@endothermicdev endothermicdev mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahanaFarooqui ShahanaFarooqui ShahanaFarooqui left review comments

@vincenzopalazzo vincenzopalazzo vincenzopalazzo left review comments

@niftynei niftynei niftynei left review comments

@cdecker cdecker cdecker left review comments

Assignees

@rustyrussell rustyrussell

Labels
None yet
Projects
None yet
Milestone
v23.08
Development

Successfully merging this pull request may close these issues.
5 participants
@rustyrussell @cdecker @niftynei @vincenzopalazzo @ShahanaFarooqui