Persist feature bits across restarts #6308
Conversation
wallet/db.c
Outdated
| @@ -949,6 +949,7 @@ static struct migration dbmigrations[] = { | |||
| {NULL, migrate_invalid_last_tx_psbts}, | |||
| {SQL("ALTER TABLE channels ADD channel_type BLOB DEFAULT NULL;"), NULL}, | |||
| {NULL, migrate_fill_in_channel_type}, | |||
| {SQL("ALTER TABLE peers ADD feature_bits BLOB DEFAULT NULL;"), NULL}, | |||
There was a problem hiding this comment.
Yeah, indent is wrong.
a5cdece to
0aecbdf
Compare
|
anecdotally seems to fix me test issues in #6035 locally, if I get a concept ACK I'll rebase to make sure on the other PR |
0aecbdf to
1464a63
Compare
lightningd/peer_control.c
Outdated
| @@ -1403,7 +1407,7 @@ void peer_connected(struct lightningd *ld, const u8 *msg) | |||
| peer = peer_by_id(ld, &id); | |||
| if (!peer) | |||
| peer = new_peer(ld, 0, &id, &hook_payload->addr, | |||
| hook_payload->incoming); | |||
| NULL, hook_payload->incoming); | |||
There was a problem hiding this comment.
... use their_features here.
And
...
else
peer_updated_features(peer, their_features).
Though frankly that function is only called once and is going to be clearer open-coded IMHO.
There was a problem hiding this comment.
did it in the open, removed peer_update_features
e2a70cb to
f890be6
Compare
|
took all feedback, pushed a basic test that shows peer feature persistence. Does this deserve a changelog? |
973f891 to
a37a4c2
Compare
|
Unrelated(?) CI timeout. Would like to see a proper postgres run in CI since it caught one logic issue prior. |
lightningd/peer_control.c
Outdated
| { | ||
| tal_free(peer->their_features); | ||
| peer->their_features = tal_dup_talarr(peer, u8, their_features); | ||
| } |
There was a problem hiding this comment.
This accidentally added "tal_free(peer->their_features)" to destroy_peer. Which is harmless, but is weird, since it's a child which is freed anyway.
There was a problem hiding this comment.
oops yeah was trying to figure out memory issue and forgot to remove
wallet/db.c
Outdated
| @@ -949,6 +949,7 @@ static struct migration dbmigrations[] = { | |||
| {NULL, migrate_invalid_last_tx_psbts}, | |||
| {SQL("ALTER TABLE channels ADD channel_type BLOB DEFAULT NULL;"), NULL}, | |||
| {NULL, migrate_fill_in_channel_type}, | |||
| {SQL("ALTER TABLE peers ADD feature_bits BLOB DEFAULT NULL;"), NULL}, | |||
There was a problem hiding this comment.
Yeah, indent is wrong.
[ Whitespace fix and remove gratuitous tal_free(peer->their_features) -- RR ]
a37a4c2 to
fee7cbe
Compare
|
Ack fee7cbe |
On channel creation with a peer, we can persist feature bits of that peer and load them on restart.
This allows more sane behavior after a restart before we've reconnected with a peer, f.e. when deciding if a peer has opted in to
anysegwitwhen creating taproot outputs. Needed for #6035This PR doesn't persist for each connection, only on new channel creation.