lightningd: don't run more than one reconnect timer at once. #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In various circumstances we can start a reconnection while one is already going on. These can stockpile if the node really is unreachable. Reported-by: @whitslack Fixes: ElementsProject#5654 Changelog-Fixed: lightningd: we no longer stack multiple reconnection attempts if connections fail. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
There was a problem hiding this comment.
utACK bf20883
with a stupid question because I did not test in my local machine!
endothermicdev
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
The debug output isn't terribly descriptive but it's also not going to be in response to anything a user does (there wouldn't be a reconnect delay present) so probably best to keep it brief.
ACK bf20883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In various circumstances we can start a reconnection while one is already going on. These can stockpile if the node really is unreachable.
Reported-by: @whitslack
Fixes: #5654
Changelog-Fixed: lightningd: we no longer stack multiple reconnection attempts if connections fail.