ci: fix schema checks #5914
Closed
ci: fix schema checks #5914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the CI errors when doing `make check-source` steps 'schema-added-check' and 'schema-removed-check'. These errors prevented CI from performing these steps correctly: ``` fatal: ambiguous argument 'main': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' ``` I changed it so that CI does a `git fetch origin` at first and do the `git diff` against 'origin/master' (which then exist). Also fixed a bug in the script that was missing $$master in the same line. Also I added that the script shows the actual diff before failing, so the user quickly sees whats wrong.
|
I included this in #5841, as I needed the fix there. So lets close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the CI errors when doing
make check-sourcesteps 'schema-added-check' and 'schema-removed-check'. These errors prevented CI from performing these steps correctly:I changed it so that CI does a
git fetch originat first and do thegit diffagainst 'origin/master' (which then exist). Also fixed a bug in the script that was missing $$master in the same line.Also I added that the script shows the actual diff before failing, so the user quickly sees whats wrong.
Note 1: Without this fix, CI is not doing this schema checks correctly, but silently ignore it, as it continues after the warnings/errors.
Note 2: I tested this fix on CI ( #5913 ) and locally, it now performs correctly and aborts, telling the user that there are missing 'added'/'deprecated' annotations.