lightningd: figure out optimal channel *before* forward_htlc hook, allow override #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48b2657 to
da7c4f7
Compare
da7c4f7 to
f007382
Compare
|
ACK f007382 |
f007382 to
4c185cf
Compare
|
Rebased and fixed a conflict, let's see if CI is happy now. |
4c185cf to
1a7dc16
Compare
1a7dc16 to
988b0c9
Compare
|
Rebased onto #5625 and fixed "Changelod" to "Changelog" typo in commit message! |
|
Most likely requires #5592 to pick up the BOLT changes |
Otherwise what the hook sees is actually a lie, and if it sets it we might override it. The side effect is that we add an explicit "forward_to" field, and allow hooks to override it. This lets a *hook* control channel choice explicitly. Changelod-Added: Plugins: `htlc_accepted_hook` return can specify what channel to forward htlc to. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
988b0c9 to
b266c30
Compare
|
Trivial rebase to pick up lnprototest fixes... Ack b266c30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise what the hook sees is actually a lie, and if it sets it we might override it.
The side effect is that we add an explicit "forward_to" field, and allow hooks to override it. This lets a hook control channel choice explicitly.
Changelod-Added: Plugins:
htlc_accepted_hookreturn can specify what channel to forward htlc to.(Interestingly, this fell out of the blinded payments work, where we can be given the peer, rather than the channel, to forward to).