Cleanup fd shuffle #4877
Cleanup fd shuffle #4877
Conversation
ccan/ccan/json_escape/json_escape.c
Outdated
| size_t i; | ||
| for (i = 0; i < len; i++) { |
There was a problem hiding this comment.
I didn't catch we need to use this old syntax for the for loop, why not just?
| size_t i; | |
| for (i = 0; i < len; i++) { | |
| for (size_t i = 0; i < len; i++) { |
There was a problem hiding this comment.
This is the ccan library, which seeks to be more portable. Declarations in for are C99, but the ccan library might very well be compiled with an older C standard.
C-lightning is C99 (actually it is GNU C99, i.e. C99 with some GNU-specific extensions) but the ccan sub-library is technically a separate project that is upstream of C-lightning, so we just copy the ccan code. And as mentioned, ccan could be compiled in an older C standard, so the ccan modules have to use older standards.
ccan/ccan/pipecmd/pipecmd.c
Outdated
| @@ -115,7 +116,8 @@ pid_t pipecmdarr(int *fd_tochild, int *fd_fromchild, int *fd_errfromchild, | |||
| goto fail; | |||
|
|
|||
| if (childpid == 0) { | |||
| for (int i = 0; i < num_child_close; i++) | |||
| int i; | |||
There was a problem hiding this comment.
Mh, sure that I'm missing something related to C? Here we could avoid the double declaration of i, but not sure that it is that the motivation
It's both complex and flawed, as ZmnSCPxj points out. Make a generic fd ordering routine, and use it. Plus, test it! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8dee0f4 to
a7d35c4
Compare
|
Fixed from @ZmnSCPxj feedback and rebased... |
Builds on #4872
Changelog-None