Add a status field to listpeers indicating where an HTLC is currently being held
#4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f944222 to
a8d33c6
Compare
rustyrussell
reviewed
Jun 4, 2021
Comment on lines
+58
to
+60
|
|
||
| /* A simple text annotation shown in `listpeers` */ | ||
| char *status; |
There was a problem hiding this comment.
This seems to be in the wrong commit?
| hin->status = | ||
| tal_fmt(hin, "Waiting for the htlc_accepted hook of plugin %s", | ||
| plugin->shortname); | ||
|
|
There was a problem hiding this comment.
You presumably should initialize this to NULL everywhere hin is allocated?
|
Got my commits mixed up it seems, I'll reslice them and update here. |
We will start annotating some of the in-memory objects with a message indicating which plugin currently is processing the hook.
ff23a72 to
5dc4b55
Compare
|
Missing regeneration of files, fixed (and trivial rebase on master). Ack 5dc4b55 |
|
Oops, and you freed it without setting to NULL, causing a use-after-free. |
Annotating the htlc in `listpeers` with their current status, and which plugin is currently holding on to them with their `htlc_accepted` hook can help us debug where plugins may go wrong. Changelog-Added: jsonrpc: HTLCs in `listpeers` are now annotated with a status if they are waiting on an `htlc_accepted` hook of a plugin.
5dc4b55 to
b89ce78
Compare
|
Ack b89ce78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging where an HTLC is currently being held can help us identify
plugins that are not behaving correctly. On top of the pure
statusfield in the
htlcsarray we also print debug messages when enteringand leaving a plugin hook, so logs are a bit more helpful too.