Dual-Funding Flag Day #4427
Merged
Dual-Funding Flag Day #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a61e21 to
82bdc4b
Compare
82bdc4b to
e91d19c
Compare
|
Trivial rebase now previous PR merged. Ack e91d19c |
e91d19c to
cc76cf9
Compare
|
Trivial re-rebase. Ack b146b83 |
b146b83 to
a6aa04e
Compare
|
I screwed up the rebase (accidentally moved an unrelated feature into experimental). Fixed now, waiting for CI. Ack b146b83 |
a6aa04e to
913ea4e
Compare
|
Re-rebased, fixed up disconnect tests which need DEVELOPER. |
946f8bf to
236af89
Compare
675aa4a to
ac25f23
Compare
| 28/29 | `option_dual_fund` | Use v2 of channel open, enables dual funding | IN9 | `option_anchor_outputs`, `option_static_remotekey` | [BOLT #2](02-peer-protocol.md) |
Use designated feature bit, instead of future-bit.
You can now activate dual-funded channels using the `--experimental-dual-fund` flag Changelog-Changed: Config: `--experimental-dual-fund` runtime flag will enable dual-funded protocol on this node
Aligns the feature bit number to the name-label. Is this correct?
They must be marked DEVELOPER-only. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The logs we're looking for don't exist anymore, we got rid of them.
83a1227 to
5fd2143
Compare
|
Rebased, fixed conflicts in tests. Ack 5fd2143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert dual-funding activation to actually use the runtime flag
--experimental-dual-fund(prior to this you'd need both the runtime flag and have built with the--enable-experimental-featuresconfigured).Built on top of #4424; new commits start at 4eef3db.