Offers: Part 1, Spec import and basic infrastructure #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis CI bot is failing on every PR! |
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is a bridge for offers which use x-only pubkeys, and the current code which doesn't. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
BOLT 12 introduces this as a new fundamental type, which lets us easily validate them. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…sage. Offers don't use the checksum, as they're signed. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
896bfa8 to
4021701
Compare
cdecker
approved these changes
Dec 8, 2020
| @@ -348,3 +348,15 @@ void towire_bitcoin_signature(u8 **pptr, const struct bitcoin_signature *sig) | |||
| towire_secp256k1_ecdsa_signature(pptr, &sig->s); | |||
| towire_u8(pptr, sig->sighash_type); | |||
| } | |||
|
|
|||
| void towire_bip340sig(u8 **pptr, const struct bip340sig *bip340sig) | |||
There was a problem hiding this comment.
Why not call this with something more memorable? I personally find referencing by BIP number confusing.
There was a problem hiding this comment.
It's the name I used in the spec. I can change both, but we called the previous type signature so I need something distinct from that.
Comment on lines
+37
to
+41
| num_chains = tal_count(chains); | ||
| if (num_chains == 0) { | ||
| num_chains = 1; | ||
| chains = &chainparams_for_network("bitcoin")->genesis_blockhash; | ||
| } |
There was a problem hiding this comment.
No, it points into a static array.
common/bolt12.c
Outdated
Comment on lines
64
to
66
| int badf; | ||
|
|
||
| badf = features_unsupported(our_features, features, |
There was a problem hiding this comment.
Nit: merge these lines or move int badf to top.
…voice Note the collapse of '+\s*' and the test cases from the spec. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
For inclusion in the onion as a reply path. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
4021701 to
b374dd9
Compare
|
Trivial change to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOLT 12 import, and various helpers to support that (offers, invoice_request, invoice) including signing infrastructure.
Almost all is EXPERIMENTAL_FEATURES, though we'll probably move to a runtime option before release.
Changelog-None