Added proxy information to plugin configuration #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ca3e2e to
f45c772
Compare
|
Ack f45c772 |
|
Please add a "Changelog-Added: Plugins: Proxy information now provided in Thanks! |
Changelog-Added: Plugins: Proxy information now provided in init.configuration." Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
f45c772 to
e0e82a3
Compare
|
@rustyrussell Done! Thanks for review this! |
|
ACK e0e82a3 |
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Sep 8, 2020
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
rustyrussell
pushed a commit
that referenced
this pull request
Sep 9, 2020
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added a commit
to clightning4j/JRPClightning
that referenced
this pull request
Sep 13, 2020
ElementsProject/lightning#4010 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vibhaa
pushed a commit
to spider-pcn/lightning
that referenced
this pull request
Mar 24, 2021
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
With this PR, I'm proposing my idea to add a couple of the information to the proxy during the plugin configuration.
Inside my test to develop a new plugin, I noted the necessity to know if the node has the proxy enabled, the solution was to add a plugin option but I think this is redundant propriety during the node setup!
Another solution is to use the
listconfigsto set up the connection inside the plugin but in some cases the method plugin call before to start some plugin methods! For instance, an alternative backend bitcoin/element that overrides the pluginbcliI hope that I'm losing nothings.