Fixup min-capacity-msat semantics in preparation for anchor outputs. #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And document exactly what it does: insist that an HTLC can pass of this value (module assumptions of feerate). Note that we remove the "is_opener" test from the capacity calculation for anchor fees: it doesn't matter which side it is, someone has to pay for anchor fees to it deducts from capacity. This change breaks the test, which we rewrite. Changelog-Changed: config: `min-capacity-sat` is now stricter about checking usable capacity of channels. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's now easy to fix. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…_anchor_outputs With a feerate of 7500perkw and subtracting 660 sats for anchors, a 20,000 sat channel has capacity about 9800 sat, below our default: You gave bad parameters: channel capacity with funding 20000sat, reserves 546sat/546sat, max_htlc_value_in_flight_msat is 18446744073709551615msat, channel capacity is 9818sat, which is below 10000000msat So bump channel amounts. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
83c593a to
21b5bdc
Compare
niftynei
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I disabled this initially for option_anchor_outputs. I revisited it, and discovered strange semantics: we neither used the number of sats they gave as a minimum, nor used it as an actual capacity.
Clarify what this option does: tries to ensure reasonable throughput.