Multiwithdraw #3812
Merged
Multiwithdraw #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa159fb to
c9ecc3f
Compare
|
Reimplemented as a plugin. Not sure how this relates to #3867.. |
a1425ca to
dbf0e2f
Compare
|
Rebased, also added missing dust limit checks. |
dbf0e2f to
3a6ba87
Compare
rustyrussell
approved these changes
Sep 8, 2020
| "multiwithdraw", | ||
| "bitcoin", | ||
| "Send to multiple {outputs} via a single Bitcoin transaction.", | ||
| "Send to multiple {outputs} at optiona {feerate}, spending " |
| p_req("outputs", param_outputs_array, &mw->outputs), | ||
| p_opt("feerate", param_string, &mw->feerate), | ||
| p_opt_def("minconf", param_number, &mw->minconf, 1), | ||
| p_opt("utxos", param_string, &mw->utxos), |
There was a problem hiding this comment.
param_string is ugly here, BTW. We should have a param_utxos?
3a6ba87 to
0cefc02
Compare
|
Trivial rebase on top of #3973 (which is about to be merged, once Travis is happy) |
…spending commands.
Fixes: ElementsProject#2679 Changelog-Added: JSON-RPC: New `multiwithdraw` command to batch multiple onchain sends in a single transaction. Note it shuffles inputs and outputs, does not use BIP69.
0cefc02 to
5a6222c
Compare
|
Ack 5a6222c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2679