Watchtowers attempt 3: the full channelding #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2020
0e31bcf to
ea49d81
Compare
rustyrussell
approved these changes
May 6, 2020
| msg = wire_sync_read(tmpctx, HSM_FD); | ||
| if (!msg || !fromwire_hsm_sign_tx_reply(msg, &sig)) { | ||
| status_broken("Reading sign_tx_reply: %s", tal_hex(tmpctx, msg)); | ||
| abort(); |
There was a problem hiding this comment.
status_failed(STATUS_FAIL_HSM_IO, ....
lightningd/peer_htlcs.c
Outdated
Comment on lines
1988
to
2007
| static void | ||
| commitment_revocation_hook_cb(struct commitment_revocation_payload *p, | ||
| const char *buffer, const jsmntok_t *toks){ | ||
| commitment_revocation_hook_cb(struct commitment_revocation_payload *p STEALS){ | ||
| wallet_penalty_base_delete(p->wallet, p->channel_id, p->commitnum); | ||
| } | ||
|
|
||
| REGISTER_PLUGIN_HOOK(commitment_revocation, PLUGIN_HOOK_CHAIN, | ||
| static bool | ||
| commitment_revocation_hook_deserialize(struct commitment_revocation_payload *p, | ||
| const char *buffer, | ||
| const jsmntok_t *toks) | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
|
|
||
| REGISTER_PLUGIN_HOOK(commitment_revocation, | ||
| commitment_revocation_hook_deserialize, | ||
| commitment_revocation_hook_cb, | ||
| struct commitment_revocation_payload *, | ||
| commitment_revocation_hook_serialize, | ||
| struct commitment_revocation_payload *); |
There was a problem hiding this comment.
This looks like a fixup for the previous commit, not part of pytest: Add a test for the commitment_revocation hook ?
lightningd/peer_htlcs.c
Outdated
Comment on lines
2124
to
2134
| plugin_hook_call_commitment_revocation(ld, payload, payload); | ||
| plugin_hook_call_commitment_revocation(ld, payload); | ||
| } |
Suggested-by: Rusty Russell <@rustyrussell>
We need the txs around, so don't throw them away after generating them.
`lightningd` passes in all the known penalty_bases when starting a new `channeld` instance, which tracks them internally, eventually matching them with revocations and passing them back to `lightningd` so it can create the penalty transaction. From here it is just a small step to having `channeld` also generate the penalty transaction if desired.
`channeld` will start creating the penalty transactions in one of the next commits, so it should know the penalty feerate.
Changelog-Added: plugin: Added a new `commitment_revocation` hook that provides the plugin with penalty transactions for all revoked transactions.
|
OK, I rebased to avoid the (trivial) conflicts and reordered commits so it compiles and passes tests at all points. |
|
Ack af88a72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third variant of the watchtower hook, the channelding. The main
difference with respect to #3645 is that the penalty transaction is now
created by
channeldwhich already has a contextualized connection tohsmd,so we can now drop the changes to the
hsmdwire protocol, and just add thepenalty creation capability to the connection between
hsmdandchanneld. It also removes the need to synchronously talk to thehsmdfromlightningdwhich was a bit ugly.Closes #3601
Closes #3645
Fixes #3422
Fixes #1353