Features rework #3609
Merged
Features rework #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restriction was removed from the spec as of 86c2ebcc5973a4133d3ce4d80ae1c203061a1646. We also fix up some strange formatting in that part of the documentation. Changelog-changed: We now announce multiple addresses of the same type, if given. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8b1a999 to
b97b4f3
Compare
cdecker
approved these changes
Mar 30, 2020
Comment on lines
+133
to
+134
| /* FIXME: We could allow a plugin to upgrade an optional feature | ||
| * to a compulsory one? */ |
There was a problem hiding this comment.
Probably not a good idea at runtime, and the features registered by the plugin are limited to optional featurebits only at the moment.
There was a problem hiding this comment.
Oh, are they? I didn't see that in the code or documentation?
There was a problem hiding this comment.
My bad, I misremembered. I had considered making them odd-only initially in the hope of reducing the fallout from a plugin crashing, but must've decided against it.
|
Seems CI is just getting upset at some whitespace, should be easy to fix. |
This is all typo/clarity fixes, no substantive changes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This will be needed for wumbo, for example. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is to prepare for dynamic features, including making plugins first class citizens at setting them. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This cleans up the boutique handling of features, and importantly, it means that if a plugin says to offer a feature in init, we will now *accept* that feature. Changelog-Fixed: Plugins: setting an 'init' feature bit allows us to accept it from peers. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We now manipulate the global features directly. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
b97b4f3 to
e3b5ea4
Compare
|
ACK e3b5ea4 |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Nov 5, 2021
This surprised me, since the CHANGELOG for [0.8.2] said: We now announce multiple addresses of the same type, if given. ([3609](ElementsProject#3609)) But it lied! Changelog-Fixed: We really do allow providing multiple addresses of the same type. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Nov 6, 2021
This surprised me, since the CHANGELOG for [0.8.2] said: We now announce multiple addresses of the same type, if given. ([3609](ElementsProject#3609)) But it lied! Changelog-Fixed: We really do allow providing multiple addresses of the same type. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Nov 10, 2021
This surprised me, since the CHANGELOG for [0.8.2] said: We now announce multiple addresses of the same type, if given. ([3609](ElementsProject#3609)) But it lied! Changelog-Fixed: We really do allow providing multiple addresses of the same type. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker
pushed a commit
that referenced
this pull request
Nov 14, 2021
This surprised me, since the CHANGELOG for [0.8.2] said: We now announce multiple addresses of the same type, if given. ([3609](#3609)) But it lied! Changelog-Fixed: We really do allow providing multiple addresses of the same type. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all in preparation for a
--wumbooption.First we update the spec, which means we gain the ability to have multiple addresses of the same type.
Then we make our feature infrastructure more flexible. We keep each feature bitmap, and make sure every subdaemon which needs it has one.
This already helps the plugin-adds-features case, which wasn't complete before (we wouldn't accept features we advertized, since we were checking against our compiled-in feature set).