Opening fail fixes #3604
Merged
Opening fail fixes #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My node crashed as follows: lightningd: lightningd/peer_control.c:957: peer_connected: Assertion `!peer->uncommitted_channel' failed. In the logs I found: Running lightning_openingd: Cannot allocate memory Which reveals that we're not freeing uc in that path! Changelog-Fixed: Fix assertion on reconnect if we fail to run openingd. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
f614e78 to
0332063
Compare
cdecker
reviewed
Mar 26, 2020
| @@ -401,8 +401,8 @@ void peer_start_channeld(struct channel *channel, | |||
| take(&hsmfd), NULL)); | |||
|
|
|||
| if (!channel->owner) { | |||
| log_unusual(channel->log, "Could not subdaemon channel: %s", | |||
| strerror(errno)); | |||
| log_broken(channel->log, "Could not subdaemon channel: %s", | |||
There was a problem hiding this comment.
subdaemon as in a verb? Had to re-read it a couple of times :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is why I run a node. Of course, I should have checked it two weeks ago!