Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BOLT11 test vectors, strengthen implementation. #3481

Merged
merged 6 commits into from
Feb 5, 2020
Merged

Update BOLT11 test vectors, strengthen implementation. #3481

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fefb966
common: implement route comparison in run-bolt11.
rustyrussell Feb 2, 2020
9b1ab8a
common: add pico-BTC parsing test from proposed BOLT.
rustyrussell Feb 3, 2020
c1a8e9c
common: fix bolt11 parsing of unknown `f` versions.
rustyrussell Feb 3, 2020
8abe4c2
common: add testing for proposed bolt11 additional tests.
rustyrussell Feb 3, 2020
ab21a0d
common: add check that pico-valued invoices are round numbers.
rustyrussell Feb 3, 2020
a253e8a
common: use tabs everywhere.
rustyrussell Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion common/bolt11.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,9 +390,14 @@ static char *decode_f(struct bolt11 *b11,
fallback = scriptpubkey_witness_raw(b11, version,
f, tal_count(f));
tal_free(f);
} else
} else {
/* Restore version for unknown field! */
(*data)--;
(*data_len)++;
data_length++;
return unknown_field(b11, hu5, data, data_len, 'f',
data_length);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab vs spaces mix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I didn't fix current code. Will append a whitespace patch though


if (b11->fallbacks == NULL)
b11->fallbacks = tal_arr(b11, const u8 *, 1);
Expand Down