pytest: fix flaky 'Bad gossip' errors #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2113e1d to
e21ea85
Compare
e21ea85 to
6a8085c
Compare
Sometimes the l3 seeker asks for scids, and the reply contains the channel which is then closed by the time it checks, so it considers the updates bad gossip. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We're about to change it so we always send our local messages, which breaks this test. Add a new node which doesn't have any local messages, so the test works correctly. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This tells clients to ignore any timestamp_filter and always send this message when it sees it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is a better fix than doing it manually, which turned out to do it in the wrong order (node_announcement followed by channel_announcement) anyway. Should fix many "Bad gossip" messages. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
6a8085c to
0dcc5f3
Compare
Merged
|
The reduction in surface by passing in the You're missing a Changelog entry in one of your commit messages, or opt-out using ACK 0dcc5f3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One real test fix, and a rework of our slightly-broken "push this msg through despite timestamp_filter" option which was causing many more "Bad gossip" order messages.