Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the user to select the autotor extern onion port #3170

Closed
wants to merge 1 commit into from
Closed

Enable the user to select the autotor extern onion port #3170

wants to merge 1 commit into from

Conversation

Saibato
Copy link
Contributor

@Saibato Saibato commented Oct 16, 2019 •
edited
Loading

Enable the local bound onion to reroute to an extern
custom port

EDIT:
in the form
--addr=autotor:[TORSERVICEIP][:TORSEVICEPORT]:torport:[EXTERNPORT]]

Signed-off-by: Saibato saibato.naga@pm.me

@Saibato Saibato marked this pull request as ready for review October 16, 2019 08:53
cdecker
cdecker requested changes Oct 17, 2019
View reviewed changes
Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense, but it requires a bit more documentation regarding the format that is accepted. For example I could not figure out how the string needs to be formatted when a port is included.

common/wireaddr.h Outdated Show resolved Hide resolved
@Saibato Saibato force-pushed the changetorport branch 2 times, most recently from 8ea2a92 to 43954aa Compare October 17, 2019 19:17
@Saibato Saibato changed the title Allow the user to select the autotor extern onion port Enable the user to select the autotor extern onion port Oct 17, 2019
@Saibato
Enable to to select the autotor extern onion port
9556a60 
Enable the local bound onion to reroute to an extern
custom port

Signed-off-by: Saibato <saibato.naga@pm.me>

Allow the user to select the autotor extern onion port

Enable the local bound onion to reroute to an extern
custom port

Signed-off-by: Saibato <saibato.naga@pm.me>

Change structure field names in torservice following the rule be odd but not weired

Signed-off-by: Saibato <saibato.naga@pm.me>
@Saibato Saibato requested a review from cdecker October 18, 2019 05:32
@Saibato
Copy link
Contributor Author

Saibato commented Nov 13, 2019

Since #3155 will add the same functionality, I close this now 😄

@Saibato Saibato closed this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdecker cdecker Awaiting requested review from cdecker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saibato @cdecker