Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option similar to bitcoind's -logtimestamps=0 #4494

Closed
jsarenik opened this issue Apr 27, 2021 · 0 comments · Fixed by #4504
Closed

Option similar to bitcoind's -logtimestamps=0 #4494

jsarenik opened this issue Apr 27, 2021 · 0 comments · Fixed by #4504

Comments

@jsarenik
Copy link
Contributor

Issue and Steps to Reproduce

I use runsvdir for process supervision and for logging I am very happy with svlogd (and djb's tai64nlocal from daemontools) so I do not expect the process to write timestamps on output. bitcoind has an option -logtimestamps which lets me turn off the timestamps in the log. What can I do with lightningd? Currently this is the double-timestamping I get:

$ tail -f log/lightningd-mainnet/current | tai64nlocal
...
2021-04-27 20:32:29.939722500 2021-04-27T18:32:29.939Z INFO    lightningd: Server started with public key 032de5c0f28f9d7d10c0c0b5ec92e83f9bf40def2bf40181c0f4330c57e58a8605, alias IRATEMONKEY-v0.10.0-52-g9470ea3 (color #032de5) and lightningd v0.10.0-52-g9470ea3

Of course I could instruct svlogd to not add timestamps on its side. I just think that it makes sense to follow the example of bitcoind and have an option to disable timestamps in the output. Thanks.
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 3, 2021
@rustyrussell
lightningd: implement --log-timestamps=false.
d3a1b6a 
Fixes: ElementsProject#4494
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 3, 2021
@rustyrussell
lightningd: implement --log-timestamps=false.
98c3b9d 
Fixes: ElementsProject#4494
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: config: New option `log-timestamps` allow disabling of timestamp prefix in logs.
@rustyrussell rustyrussell mentioned this issue May 3, 2021
Merged
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 4, 2021
@rustyrussell
lightningd: implement --log-timestamps=false.
7e8d771 
Fixes: ElementsProject#4494
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: config: New option `log-timestamps` allow disabling of timestamp prefix in logs.
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 5, 2021
@rustyrussell
lightningd: implement --log-timestamps=false.
378a39d 
Fixes: ElementsProject#4494
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: config: New option `log-timestamps` allow disabling of timestamp prefix in logs.
rustyrussell added a commit to rustyrussell/lightning that referenced this issue May 5, 2021
@rustyrussell
lightningd: implement --log-timestamps=false.
451e189 
Fixes: ElementsProject#4494
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: config: New option `log-timestamps` allow disabling of timestamp prefix in logs.
niftynei pushed a commit that referenced this issue May 5, 2021
@rustyrussell @niftynei
lightningd: implement --log-timestamps=false.
9825f32 
Fixes: #4494
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: config: New option `log-timestamps` allow disabling of timestamp prefix in logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightningd: implement --log-timestamps=false. rustyrussell/lightning
1 participant
@jsarenik