-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regular lightning payment crashes lightning node #4488
Comments
Thank you very much for the very extensive debugging information, it's been very helpful to find potential culprits 👍 Decoding the invoice I get the following: {
"currency": "bc",
"created_at": 1619018481,
"expiry": 172800,
"payee": "02aecde3b3dde450889755d4dbce538e6b9e9dfa7702d14b5bc5c4379e1b330392",
"msatoshi": 1800000,
"amount_msat": "1800000msat",
"description": "BDT invoice 399",
"min_final_cltv_expiry": 18,
"payment_secret": "1118b4e93d0ca5a59515117fd30666d06f4d855f3f5a800bdeb1b5883bca002c",
"features": "028200",
"routes": [
[
{
"pubkey": "02888244029c5909593038ab19f269947c720de3423e491791b46c7c92f76279b6",
"short_channel_id": "618839x2339x0",
"fee_base_msat": 1,
"fee_proportional_millionths": 1,
"cltv_expiry_delta": 34
}
]
],
"payment_hash": "2d50531656a40e318a88e86c08fde5c29dd74685555c6801c5b821b491d8f1b1",
"signature": "3044022036410d652d37e60552e649eecc639d1719a9c099353cf6678a4bdc9a3174e0e2022071c93a7952b970227f02e541773b9569f80997e0c5aa1f8506899dfe7c12255c"
} So the payee / recipient is
Which can happen for a variety of reasons (networking issue would be my guess here), and the node doesn't get reconnected. So we seem to have an issue filtering routehints in the where we are the entrypoint to the routehint. In this scenario we are
I'll reproduce the issue based on this, and figure out what goes wrong here as soon as possible. |
This is another example around the same time when I was investigating the issue, where it seems another channel died, not the channel with the payee. Maybe it's useful as well, maybe not. Good luck!
|
Looking at the traceback a bit closer it seems the There is a Lines 220 to 227 in 9470ea3
And it could be either lightning/plugins/libplugin-pay.c Lines 2353 to 2356 in 9470ea3
Leaving us with lightning/plugins/libplugin-pay.c Lines 2682 to 2684 in 9470ea3
However I can't see how that could possibly return a lightning/plugins/libplugin-pay.c Lines 19 to 36 in 9470ea3
Maybe @rustyrussell has an idea? |
Above my pay grade but anyways: What if |
This one gives a bit more information:
|
There are a couple of ways this can happen, but we shouldn't crash. Fixed ElementsProject#4488 Fixes ElementsProject#4533 Changelog-Fixed: pay: Fixed an issue when filtering routehints when we can't find ourselves in the local network view.
There are a couple of ways this can happen, but we shouldn't crash. Fixed ElementsProject#4488 Fixes ElementsProject#4533 Changelog-Fixed: pay: Fixed an issue when filtering routehints when we can't find ourselves in the local network view.
Thanks to both of you for fixing this! |
EDIT: now, 2 days later, it's working again. So what was going on here?
Sending node A: ""version": "v0.10.0-40-ga8fde9f" (the node that crashes during the payment)
Receiving node B: "version": "v0.10.0-40-ga8fde9f" (this one doesn't crash)
The following payment crashes my node consistently:
lightning-cli pay lnbc18u1psgqsh3pp594g9x9jk5s8rrz5gapkq3l09c2waw35924wxsqw9hqsmfywc7xcsdqcgfz9ggrfdemx76trv5srxwfexqy9gcqcqpjsp5zyvtf6fapjj6t9g4z9laxpnx6ph5mp2l8adgqz77kx6csw72qqkqrzjq2ygy3qzn3vsjkfs8z43nunfj378yr0rgglyj9u3k3k8eyhhvfumvzt32uqqjgcqqqqqqqqpqqqqqqgqyg9qy9qsqxeqs6efdxlnq25hxf8hvccuazuv6nsyex570veu2f0wf5vt5ur38rjf609ftjupz0upw2sth8w2kn7qfjlsvt2sls5rgn8070sfz2hqp9f07rr
Also I'm able to
keysend
from node B to A but not from A to B. I don't know what happened, the channel has enough liquidity at both sides of the channel and payments had always worked. Thekeysend
payment is also in the crash report (butpay
crashed the node, notkeysend
, although both suffer from the same problem it seems). Edit: I still am able tokeysend
from A to another node, just not that node B.NOTE: both nodes have:
Crash report:
The text was updated successfully, but these errors were encountered: