Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Crucial" plugins #3213

Closed
darosior opened this issue Oct 26, 2019 · 1 comment · Fixed by #3890
Closed

"Crucial" plugins #3213

darosior opened this issue Oct 26, 2019 · 1 comment · Fixed by #3890

Comments

@darosior
Copy link
Contributor

darosior commented Oct 26, 2019

For now, if a plugin dies before lightningd for whatever reason while having registered a hook, lightningd will hang forever when sending a "hook request" to the plugin. We might want to rely more on plugin for more crucial operations (for example, RPC wallet locking, Bitcoin network interface), hence a special kind of plugins -"crucial" plugins- might be defined so that if they die, lightningd does too.
lightningd isnt stuck anymore as of #3496, and #3213 (comment) is overall a better proposal.

@niftynei niftynei added good first issue good for onboarding enhancement labels Oct 28, 2019
@niftynei niftynei changed the title [Good first issue] "Crucial" plugins "Crucial" plugins Oct 28, 2019
@ZmnSCPxj
Copy link
Contributor

ZmnSCPxj commented Dec 26, 2019

As an added idea, we should mark plugins that are part of our distribution, and which implement commands that were previously built-in to lightningd, as crucial as well. #3373 shows that some boutique installations processes do not properly install our distributed plugins.

This might not necessarily be the same as the "crucial" concept described here, however. We need to be able to mark plugins as needed by lightningd even at the start, i.e. we have an option flag --crucial-plugin=foo which causes lightningd to exit immediately if those plugins never got started in the first place, and add our builtin plugins to that set, so that installations missing our "builtin" plugins will fail immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants