Some aliases no longer visible in listnodes #3194

ghost · 2019-10-21T22:46:08Z

I automatically find aliases via: lightning-cli listnodes

Since I updated to v0.7.3some aliases are no longer part of listnodes. The IDs are there but without aliases. I suspect it happens with c-lightning versions <= 0.7.2. LND and Eclair aliases seem the same (see my website and look for alias_unknown)

For example ln.rene-pickhardt.de. The node ID is in listnodes (I even have a channel with that node) but without the alias.

`getinfo` output

Alias: Bitkoins.nl
Version: v0.7.3rc3"

The text was updated successfully, but these errors were encountered:

darosior · 2019-10-22T06:52:35Z

Since I updated to v0.7.3

Which version ? There has been some gossip fixups between the rcs.

ghost · 2019-10-22T08:57:29Z

Version: v0.7.3rc3 (that was written under getinfo output.) but the problem started already with rc2.

niftynei · 2019-10-22T14:06:28Z

missing aliases is a side-effect of your node not having the node_announcement gossip message for that node.

prior RC's of c-lightning weren't being very aggressive with pushing out their own node_announcements, see #3152

ghost · 2019-10-22T14:39:12Z

@niftynei So it's only a problem with c-lightning versions 0.7.3.rc1 and/or 0.7.3.rc2 or also with older versions of c-lightning? If only with the two rcs, I will close the issue.

whitslack · 2019-10-24T06:05:03Z

It was a problem in 0.7.2 too. See #2969.

I am still experiencing the issue on 0.7.3rc3. Even after my node has been running for three days on 0.7.3rc3, I am still missing node announcements for a sizable fraction of my connected peers.

niftynei · 2019-10-24T07:06:54Z

There are two issues to discuss here, which have the same net result— your node appears to be missing aliases for other nodes.

In the case of “my node is missing alias information from recent c-lightning nodes”, this is likely due to them not sending them very aggressively. #3152 addresses this, but requires affected nodes to upgrade

In the case of “Im missing large swaths of aliases from nodes, not just from clightning peers”, this is typically a result of not asking our peers for a wide enough range to net the missing information. It should be fixed in RC3 (we now look for a wide range of missing node announcements to ask our peers about). If you’re still having trouble, you can give it a kick by deleting* your gossip store, this will resync all the gossip en masse. Note that if the reason they’re missing is because the above issue, this won’t do much to help as it’s unlikely your peers have the missing information either.

*i.e. stop your node, rename the gossip store to gossip_store.bak, restart node

whitslack · 2019-10-24T07:14:37Z

@niftynei: Thanks for the clarifications. Even if I don't zap my gossip_store, shouldn't my node eventually fill in all the node announcements it's missing just due to routine gossip refreshes? How long is that expected to take?

niftynei · 2019-10-24T07:25:54Z

@whitslack well that depends on why the announcements are missing. assuming that they’re relatively well represented on other nodes, they should get picked up by the gossip seeker eventually. I’d need to check but I believe it was changed to run once every ~24hrs

whitslack · 2019-10-24T07:42:08Z

@niftynei: 100 of my 386 peers are showing no alias and no color after my node has been up for 62 hours. Does this suggest that the seeker is malfunctioning?

$ lightning-cli listpeers | jq -r '.peers[] | .id' | xargs -d'\n' -n1 lightning-cli listnodes | jq '.nodes[] | has("alias") or has("color")' | awk '{ counts[$0]++ } END { for (value in counts) print value, counts[value] }'
false 100
true 286

ghost · 2019-10-24T08:27:48Z

I've updated to the latest version (v0.7.3rc3-2-g0985c6e), removed the gossip_store (like I've done before) and the problem is still there for some nodes (probably only with c-lightning nodes).

Using whitslack's command:

false 7
true 13

darosior · 2019-10-24T08:32:22Z

probably only with c-lightning nodes

Yep, I've seen this on my node and it's indeed only C-lightning nodes. They might not have upgraded yet.

whitslack · 2019-10-24T08:44:29Z

it's indeed only C-lightning nodes.

@darosior: How do you tell what software your peer is running? I'd love to instrument that, but I haven't found a way.

darosior · 2019-10-24T09:39:35Z

@darosior: How do you tell what software your peer is running? I'd love to instrument that, but I haven't found a way.

Actually checking 1ML ^^
On this one you can give personal informations, and the node I'm connected to did. You could also check messages but it's more complicated..

ghost · 2019-10-24T09:46:01Z

@whitslack I only know they are c-lightning nodes because I decided to only connect to c-lightning nodes a couple of months ago when I was often getting fatal errors with LND nodes (this issue has now been resolved by ignoring these error messages). I found the c-lightning nodes looking for node IDs in the issues. Nevertheless an interesting question.

darosior · 2019-10-24T09:52:07Z

@whitslack I only know they are c-lightning nodes because I decided to only connect to c-lightning nodes a couple of months ago when I was often getting fatal errors with LND nodes (this issue has now been resolved by ignoring these error messages). I found the c-lightning nodes looking for node IDs in the issues. Nevertheless an interesting question.

Unfortunately so I did...

poperbu · 2019-10-29T19:17:58Z

I updated my node from 7.2 to 7.3 and I have the same problem. only 1038 of 4615 listed nodes are not empty.

darosior · 2019-10-29T20:10:57Z

Hello @poperbu, it must be due to the remote side which has not updated yet

poperbu · 2019-10-29T21:47:36Z

ok, I understand now,...so We need to wait that all nodes update their info? It is a problem for plugins and tools that use listnodes calls, if we need to wait long time to know the alias...

whitslack · 2019-10-29T21:57:40Z

As much as I would love to believe that 114 of my 392 peers are running buggy C-Lightning release candidates, I think we all know that C-Lightning just isn't that popular. No, our lack of node announcements is not solely due to a plethora of buggy C-Lightning release candidates running in the wild. It is evident that there is still a logic error in the gossip code of C-Lightning 0.7.3.

It really, really doesn't matter. But we were dramatically reducing our view of the network: In my gossip_store (mainnet): channel_announcement: 30349 channel_update: 55119 node_announcment: 1783 Changelog-Fixed: No longer discard most node_announcements (fixes ElementsProject#3194) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

It really, really doesn't matter. But we were dramatically reducing our view of the network: In my gossip_store (mainnet): channel_announcement: 30349 channel_update: 55119 node_announcment: 1783 Changelog-Fixed: No longer discard most node_announcements (fixes #3194) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

ghost · 2019-11-15T13:06:22Z

Yep, this commit solves the issue. Thanks to all!

rustyrussell · 2019-11-16T00:02:19Z

OK, if you want to fix existing nodes, I've written a script to do so. I've appended it to the Release files, along with a canned set of node_announcements for mainnet

https://github.com/ElementsProject/lightning/releases/download/v0.7.3/insert-unknown-nodes.sh
https://github.com/ElementsProject/lightning/releases/download/v0.7.3/node-announces.tar.xz

darosior mentioned this issue Nov 6, 2019

gossipd: allow node_announcements and channel_announcements with unsu… #3247

Merged

ghost mentioned this issue Nov 10, 2019

Connected and disconnected at the same time #3252

Open

rustyrussell mentioned this issue Nov 15, 2019

gossipd: don't discard node_announcements with old timestamps. #3262

Merged

cdecker closed this as completed in #3262 Nov 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some aliases no longer visible in listnodes #3194

Some aliases no longer visible in listnodes #3194

ghost commented Oct 21, 2019

darosior commented Oct 22, 2019

ghost commented Oct 22, 2019

niftynei commented Oct 22, 2019 •

edited

Loading

ghost commented Oct 22, 2019

whitslack commented Oct 24, 2019

niftynei commented Oct 24, 2019 •

edited

Loading

whitslack commented Oct 24, 2019

niftynei commented Oct 24, 2019

whitslack commented Oct 24, 2019 •

edited

Loading

ghost commented Oct 24, 2019 •

edited by ghost

Loading

darosior commented Oct 24, 2019

whitslack commented Oct 24, 2019

darosior commented Oct 24, 2019 •

edited

Loading

ghost commented Oct 24, 2019 •

edited by ghost

Loading

darosior commented Oct 24, 2019

poperbu commented Oct 29, 2019

darosior commented Oct 29, 2019

poperbu commented Oct 29, 2019

whitslack commented Oct 29, 2019

ghost commented Nov 15, 2019

rustyrussell commented Nov 16, 2019

Some aliases no longer visible in listnodes #3194

Some aliases no longer visible in listnodes #3194

Comments

ghost commented Oct 21, 2019

getinfo output

darosior commented Oct 22, 2019

ghost commented Oct 22, 2019

niftynei commented Oct 22, 2019 • edited Loading

ghost commented Oct 22, 2019

whitslack commented Oct 24, 2019

niftynei commented Oct 24, 2019 • edited Loading

whitslack commented Oct 24, 2019

niftynei commented Oct 24, 2019

whitslack commented Oct 24, 2019 • edited Loading

ghost commented Oct 24, 2019 • edited by ghost Loading

darosior commented Oct 24, 2019

whitslack commented Oct 24, 2019

darosior commented Oct 24, 2019 • edited Loading

ghost commented Oct 24, 2019 • edited by ghost Loading

darosior commented Oct 24, 2019

poperbu commented Oct 29, 2019

darosior commented Oct 29, 2019

poperbu commented Oct 29, 2019

whitslack commented Oct 29, 2019

ghost commented Nov 15, 2019

rustyrussell commented Nov 16, 2019

`getinfo` output

niftynei commented Oct 22, 2019 •

edited

Loading

niftynei commented Oct 24, 2019 •

edited

Loading

whitslack commented Oct 24, 2019 •

edited

Loading

ghost commented Oct 24, 2019 •

edited by ghost

Loading

darosior commented Oct 24, 2019 •

edited

Loading

ghost commented Oct 24, 2019 •

edited by ghost

Loading