db: Admit null value inside the db_bind_sha256

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
ElementsProject · Sep 14, 2021 · 6f5fcaa · 6f5fcaa
1 parent 133f1d7
commit 6f5fcaa
Show file tree

Hide file tree

Showing 12 changed files with 181 additions and 793 deletions.
diff --git a/doc/lightning-listsendpays.7 b/doc/lightning-listsendpays.7
diff --git a/doc/lightning-listsendpays.7.md b/doc/lightning-listsendpays.7.md
@@ -4,15 +4,15 @@ lightning-listsendpays -- Low-level command for querying sendpay status
 SYNOPSIS
 --------
 
-**listsendpays** \[*bolt11*\] \[*payment\_hash*\] [\*status*\]
+**listsendpays** \[*bolt11*\] \[*payment\_hash*\] \[*status*\]
 
 DESCRIPTION
 -----------
 
 The **listsendpays** RPC command gets the status of all *sendpay*
 commands (which is also used by the *pay* command), or with *bolt11* or
 *payment\_hash* limits results to that specific payment. You cannot
-specify both. It is possible filter the payments also by status.
+specify both. It is possible filter the payments also by *status*.
 
 Note that in future there may be more than one concurrent *sendpay*
 command per *pay*, so this command should be used with caution.

diff --git a/external/lnprototest b/external/lnprototest
diff --git a/wallet/db.c b/wallet/db.c
@@ -1697,7 +1697,10 @@ void db_bind_preimage(struct db_stmt *stmt, int pos, const struct preimage *p)
 
 void db_bind_sha256(struct db_stmt *stmt, int pos, const struct sha256 *s)
 {
-	db_bind_blob(stmt, pos, s->u.u8, sizeof(struct sha256));
+	if(!s)
+		db_bind_null(stmt, pos);
+	else
+		db_bind_blob(stmt, pos, s->u.u8, sizeof(struct sha256));
 }
 
 void db_bind_sha256d(struct db_stmt *stmt, int pos, const struct sha256_double *s)

diff --git a/wallet/db_postgres_sqlgen.c b/wallet/db_postgres_sqlgen.c
diff --git a/wallet/db_sqlite3_sqlgen.c b/wallet/db_sqlite3_sqlgen.c
+4 −0		.dockerignore
+30 −0		.github/workflows/build.yml
+16 −0		.github/workflows/testing.yml
+2 −1		Makefile
+1 −1		README.md
+75 −0		docker/Dockerfile.clightning
+7 −0		docker/docker-compose.yml
+3 −0		docker/entrypoint.sh
+2 −1		lnprototest/__init__.py
+38 −2		lnprototest/backend/bitcoind.py
+2 −2		lnprototest/clightning/clightning.py
+1 −1		lnprototest/clightning/requirements.txt
+1 −1		lnprototest/commit_tx.py
+3 −6		lnprototest/proposals.py
+14 −0		lnprototest/utils.py
+9 −8		requirements.txt
+11 −7		tests/conftest.py
+1 −1		tests/pytest.ini
+70 −24		tests/test_bolt2-30-channel_type-open-accept-tlvs.py
+2 −2		tools/check_quotes.py