Port tweakfedpegscript from liquid-deamon #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
reviewed
Jun 19, 2018
qa/rpc-tests/pegging.py
Outdated
| @@ -168,6 +168,7 @@ def test_pegout(parent_chain_addr, sidechain): | |||
| bitcoindstart = bitcoin_bin_path+"/bitcoind -datadir="+bitcoin_datadir | |||
| subprocess.Popen(bitcoindstart.split(), stdout=subprocess.PIPE) | |||
|
|
|||
|
|
|||
| /* Not shown in help */ | ||
| { "hidden", "setmocktime", &setmocktime, true, {"timestamp"}}, | ||
| { "hidden", "echo", &echo, true, {"arg0","arg1","arg2","arg3","arg4","arg5","arg6","arg7","arg8","arg9"}}, | ||
| { "hidden", "echojson", &echo, true, {"arg0","arg1","arg2","arg3","arg4","arg5","arg6","arg7","arg8","arg9"}}, | ||
| { "hidden", "echojson", &echo, true, {"arg0","arg1","arg2","arg3","arg4","arg5","arg6","arg7","arg8","arg9"}}, |
There was a problem hiding this comment.
Re-added the line that was removed: The space change was just to fix the column alignment in this line.
|
ACK otherwise |
|
Perhaps it would be nice to wait for #362 ? |
|
If I had to guess I'd say it would be simpler to merge this first and rebase the other PR, since it's still dependent on yet another PR. |
|
Needs squash |
Port tweakfedpegscript from liquid
|
@instagibbs Squashed (I hope) |
|
ACK |
instagibbs
added a commit
that referenced
this pull request
Jun 22, 2018
9bcfdd8 Port tweakfedpegscript from liquid (Mike)
gwillen
pushed a commit
that referenced
this pull request
Jun 1, 2022
…-sort Peers table 986bf78 qt: Emit dataChanged signal to dynamically re-sort Peers table (Hennadii Stepanov) Pull request description: [By default](https://doc.qt.io/qt-5/qsortfilterproxymodel.html#details), the `PeerTableSortProxy` > dynamically re-sorts ... data whenever the original model changes. That is not the case on master (8cdf917) as in ecbd911 (#164) no signals are emitted to notify about model changes. This PR uses a dedicated [`dataChanged`](https://doc.qt.io/qt-5/qabstractitemmodel.html#dataChanged) signal. Fixes #367. An alternative to #374. ACKs for top commit: jarolrod: ACK 986bf78 Tree-SHA512: dcb92c2f9a2c632880429e9528007db426d2ad938c64dfa1f1538c03e4b62620df52ad7daf33b582976c67b472ff76bc0dae707049f4bbbd4941232cee9ce3d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the changes made in liquid-deamon to add tweakfedpegscript in rpc/misc.cpp.